[SPARK-45302][PYTHON] Remove PID communication between Python workers when no demon is used #43087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ueshin |
673d513 to
b1ba9aa
Compare
b1ba9aa to
da6a979
Compare
ueshin
approved these changes
Sep 26, 2023
|
Merged to master. |
|
I am going to revert this for now - I am cleaning up and refactoring workers. I will bring this back in again later. |
HyukjinKwon
added a commit
that referenced
this pull request
Apr 25, 2024
…workers when no demon is used" ### What changes were proposed in this pull request? This PR reverts #43087. ### Why are the changes needed? To clean up those workers. I will make a refactoring PR soon. I will bring them back again with a refactoring PR. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46195 from HyukjinKwon/SPARK-45302-revert. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…workers when no demon is used" ### What changes were proposed in this pull request? This PR reverts apache#43087. ### Why are the changes needed? To clean up those workers. I will make a refactoring PR soon. I will bring them back again with a refactoring PR. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46195 from HyukjinKwon/SPARK-45302-revert. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the legacy workaround for JDK 8 in
PythonWorkerFactory.Why are the changes needed?
No need to manually send the PID around through the socket.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
There are existing unittests for the daemon disabled.
Was this patch authored or co-authored using generative AI tooling?
No.