-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subtask][operator] svc generation refinement #525
Comments
cc @wangao1236 |
advancedxy
added a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Feb 6, 2023
advancedxy
added a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Feb 6, 2023
advancedxy
added a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Feb 6, 2023
advancedxy
added a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Feb 6, 2023
advancedxy
added a commit
that referenced
this issue
Feb 6, 2023
### What changes were proposed in this pull request? 1. generate headless svc for coordinators and pass this service to shuffle servers 2. makes RPCNodePort/HTTPNodePort optional for coordinators 3. remove service creation for shuffle servers. ### Why are the changes needed? This fixes #525 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? It has already been manually verified, and will add more UTs.
advancedxy
added a commit
that referenced
this issue
Feb 9, 2023
### What changes were proposed in this pull request? Add omitempty for `RPCNodePort` and `HTTPNodePort` ### Why are the changes needed? This is a bug fixes. Otherwise, rss spec cannot omit `rpcNodePort` and `httpNodePort` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the subtask
We should reconsider the service generated by RSS operator as it may not make too much sense.
Current behavior for RSS to generate svcs:
There are some ways to improves this situation:
Parent issue
#462
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: