Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#525][FOLLOWUP] fix: add omitempty tag #565

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

advancedxy
Copy link
Contributor

What changes were proposed in this pull request?

Add omitempty for RPCNodePort and HTTPNodePort

Why are the changes needed?

This is a bug fixes. Otherwise, rss spec cannot omit rpcNodePort and httpNodePort

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

@codecov-commenter
Copy link

Codecov Report

Merging #565 (f5c22f8) into master (f461460) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #565      +/-   ##
============================================
- Coverage     60.87%   60.51%   -0.36%     
+ Complexity     1796     1567     -229     
============================================
  Files           213      191      -22     
  Lines         12375    10531    -1844     
  Branches       1049      885     -164     
============================================
- Hits           7533     6373    -1160     
+ Misses         4435     3793     -642     
+ Partials        407      365      -42     
Impacted Files Coverage Δ
...storage/handler/impl/DataSkippableReadHandler.java 83.78% <0.00%> (-2.71%) ⬇️
...ava/org/apache/uniffle/server/ShuffleTaskInfo.java 98.07% <0.00%> (-1.93%) ⬇️
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️
.../java/org/apache/spark/shuffle/RssSparkConfig.java
...k/shuffle/writer/WrappedByteArrayOutputStream.java
...preduce/task/reduce/RssRemoteMergeManagerImpl.java
...e/spark/shuffle/reader/RssShuffleDataIterator.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
.../org/apache/spark/shuffle/writer/WriterBuffer.java
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangao1236
Copy link
Collaborator

LGTM

@advancedxy advancedxy merged commit 0779946 into apache:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants