-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #525][operator] refine svc creations #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping @wangao1236 to see if you have any other input. |
advancedxy
force-pushed
the
issue_525
branch
2 times, most recently
from
February 2, 2023 09:50
52a22d1
to
33f21b0
Compare
ping @wangao1236 this should be ready for review. |
advancedxy
force-pushed
the
issue_525
branch
2 times, most recently
from
February 2, 2023 11:45
6b1512c
to
82695a8
Compare
Gently ping @wangao1236. |
advancedxy
changed the title
[ISSUE-525][operator] refine svc creations
[ISSUE#525][operator] refine svc creations
Feb 6, 2023
advancedxy
changed the title
[ISSUE#525][operator] refine svc creations
[ISSUE#525][operator] #525 refine svc creations
Feb 6, 2023
advancedxy
changed the title
[ISSUE#525][operator] #525 refine svc creations
[ISSUE#525][operator] refine svc creations
Feb 6, 2023
advancedxy
force-pushed
the
issue_525
branch
3 times, most recently
from
February 6, 2023 02:10
dede8d6
to
e87cc0a
Compare
advancedxy
changed the title
[ISSUE#525][operator] refine svc creations
[ISSUE #525][operator] refine svc creations
Feb 6, 2023
wangao1236
reviewed
Feb 6, 2023
wangao1236
reviewed
Feb 6, 2023
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator_test.go
Outdated
Show resolved
Hide resolved
wangao1236
reviewed
Feb 6, 2023
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator_test.go
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
============================================
+ Coverage 59.69% 60.85% +1.15%
Complexity 1795 1795
============================================
Files 213 213
Lines 12414 12372 -42
Branches 1050 1050
============================================
+ Hits 7411 7529 +118
+ Misses 4594 4435 -159
+ Partials 409 408 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wangao1236
approved these changes
Feb 6, 2023
jerqi
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
This fixes #525
Does this PR introduce any user-facing change?
No
How was this patch tested?
It has already been manually verified, and will add more UTs.