Flaky Test: CoordinatorGrpcTest.rpcMetricsTest

[zuston]

Code of Conduct

• I agree to follow this project's Code of Conduct

Search before asking

• I have searched in the issues and found no similar issues.

Describe the flaky test

CoordinatorGrpcTest.rpcMetricsTest

Actions URL

https://github.com/apache/incubator-uniffle/actions/runs/3126470728/attempts/1

Parent issue

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[zuston]

Closed. Solved in #256

[zhengchenyu]

There is another test error related to CoordinatorGrpcTest.(https://github.com/apache/incubator-uniffle/actions/runs/6584732533/job/17889841948?pr=1250) I don’t think it is necessary to open another issue. Let’s discuss it here.

[INFO] Running org.apache.uniffle.test.CoordinatorGrpcTest
Error:  Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.078 s <<< FAILURE! - in org.apache.uniffle.test.CoordinatorGrpcTest
Error:  rpcMetricsTest  Time elapsed: 1.07 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
	at org.apache.uniffle.test.CoordinatorGrpcTest.rpcMetricsTest(CoordinatorGrpcTest.java:344)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
	...

I reproduce this problem when increase "rss.server.heartbeat.interval" and sleep before assign oldValue.
We can not guarantee that two more heartbeat. I can only guarantee that two or more heartbeat after wait two shuffle server register.