Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#244][FOLLOWUP] test: CoordinatorGrpcTest.rpcMetricsTest. #1251

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

Fix test

Why are the changes needed?

Fix: #244

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #1251 (3b5d215) into master (4f56e59) will increase coverage by 1.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1251      +/-   ##
============================================
+ Coverage     54.17%   55.25%   +1.07%     
- Complexity     2659     2660       +1     
============================================
  Files           396      376      -20     
  Lines         23013    20653    -2360     
  Branches       1971     1971              
============================================
- Hits          12467    11411    -1056     
+ Misses         9777     8547    -1230     
+ Partials        769      695      -74     

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhengchenyu

@jerqi jerqi changed the title [#244][FOLLOWUP] Flaky Test: CoordinatorGrpcTest.rpcMetricsTest. [#244][FOLLOWUP] test: CoordinatorGrpcTest.rpcMetricsTest. Oct 20, 2023
@jerqi jerqi merged commit ecb7ff0 into apache:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: CoordinatorGrpcTest.rpcMetricsTest
3 participants