[apache#244][FOLLOWUP] Flaky Test: CoordinatorGrpcTest.rpcMetricsTest.

zhengchenyu · Oct 20, 2023 · 78882bf · 78882bf
1 parent 4f56e59
commit 78882bf
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java b/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
@@ -326,22 +326,16 @@ public void shuffleServerHeartbeatTest() throws Exception {
 
   @Test
   public void rpcMetricsTest() throws Exception {
-    double oldValue =
-        coordinators
-            .get(0)
-            .getGrpcMetrics()
-            .getCounterMap()
-            .get(CoordinatorGrpcMetrics.HEARTBEAT_METHOD)
-            .get();
+    double oldValue, newValue;
     CoordinatorTestUtils.waitForRegister(coordinatorClient, 2);
-    double newValue =
+    newValue =
         coordinators
             .get(0)
             .getGrpcMetrics()
             .getCounterMap()
             .get(CoordinatorGrpcMetrics.HEARTBEAT_METHOD)
             .get();
-    assertTrue(newValue - oldValue > 1);
+    assertTrue(newValue > 1);
 
     String appId = "rpcMetricsTest";
     RssGetShuffleAssignmentsRequest request =