Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #3520]Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] #4486

Merged
merged 2 commits into from
Oct 15, 2023
Merged

[ISSUE #3520]Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] #4486

merged 2 commits into from
Oct 15, 2023

Conversation

Ricky-Qu
Copy link
Contributor

@Ricky-Qu Ricky-Qu commented Oct 14, 2023 •
edited by pandaapo
Loading

fix #3520

@Ricky-Qu Ricky-Qu changed the title Swap these 2 arguments so they are in the correct order: expected val… [ISSUE #3520]Swap these 2 arguments so they are in the correct order: expected val… Oct 14, 2023
mxsm
mxsm requested changes Oct 14, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeeHunLee Please fix code style
image

@codecov
Copy link

codecov bot commented Oct 15, 2023 •
edited
Loading

Codecov Report

Merging #4486 (38ad1f7) into master (d327ff3) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 38ad1f7 differs from pull request most recent head 9fbf7b7. Consider uploading reports for the commit 9fbf7b7 to get more accurate results

@@            Coverage Diff            @@
##             master    #4486   +/-   ##
=========================================
  Coverage     15.57%   15.58%           
- Complexity     1474     1475    +1     
=========================================
  Files           698      698           
  Lines         28205    28205           
  Branches       2633     2634    +1     
=========================================
+ Hits           4394     4396    +2     
+ Misses        23362    23361    -1     
+ Partials        449      448    -1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pandaapo pandaapo changed the title [ISSUE #3520]Swap these 2 arguments so they are in the correct order: expected val… [ISSUE #3520]Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] Oct 15, 2023
@mxsm mxsm merged commit 093fb6b into apache:master Oct 15, 2023
@pandaapo pandaapo mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Ricky-Qu @mxsm @pandaapo