[ISSUE #3520]swapped the actual value and expected value. #3594
Conversation
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
There was a problem hiding this comment.
Hi @monish-byte Please link this pr to issue#3520, how to do this you can read this docment:https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue.
|
@mxsm i read the doc you send me. Followed the steps but i am not able to click on development as it is in text format. Please guide me through it. |
|
@monish-byte edit this pr first comment and modify Fixes #. to Fixes #3520. and pr title you can modify like this: [ISSUE #3520]swapped the actual value and expected value. Attention the space between ISSUE and # |
|
No changes are needed except for lines 63-87. |
| Assert.assertEquals(config.getEventMeshEnv(),"env-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshIDC(),"idc-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshCluster(),"cluster-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshName(),"name-succeed!!!"); | ||
| Assert.assertEquals(config.getSysID(),"816"); | ||
| Assert.assertEquals(config.getEventMeshConnectorPluginType(),"connector-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshStoragePluginType(),"storage-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshSecurityPluginType(),"security-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshRegistryPluginType(),"registry-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshTracePluginType(),"trace-succeed!!!"); | ||
| Assert.assertEquals(config.getEventMeshServerIp(),"hostIp-succeed!!!"); | ||
|
|
||
| List<String> list = new ArrayList<>(); | ||
| list.add("metrics-succeed1!!!"); | ||
| list.add("metrics-succeed2!!!"); | ||
| list.add("metrics-succeed3!!!"); | ||
| Assert.assertEquals(list, config.getEventMeshMetricsPluginType()); | ||
| Assert.assertEquals(config.getEventMeshMetricsPluginType(),list); | ||
|
|
||
| Assert.assertTrue(config.isEventMeshServerSecurityEnable()); | ||
| Assert.assertTrue(config.isEventMeshServerRegistryEnable()); | ||
| Assert.assertTrue(config.isEventMeshServerTraceEnable()); | ||
|
|
||
| Assert.assertEquals("eventmesh.idc-succeed!!!", config.getEventMeshWebhookOrigin()); | ||
| Assert.assertEquals(config.getEventMeshWebhookOrigin(),"eventmesh.idc-succeed!!!"); |
There was a problem hiding this comment.
Please restore the changes in these lines, the original order of 'expect' and 'actual' is correct.
|
PR #4486 has fixed this issue better. So I close this PR. Thank you for your work. |
Fixes #3520.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation