Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] #3520

Closed
1 of 2 tasks
Alonexc opened this issue Mar 22, 2023 · 2 comments · Fixed by #4486
Closed
1 of 2 tasks

[Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] #3520

Alonexc opened this issue Mar 22, 2023 · 2 comments · Fixed by #4486
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Mar 22, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
Located at:
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/boot/EventMeshServerTest.java line 63-87
analysis and explanation:
The standard assertions library methods such as org.junit.Assert.assertEquals, and org.junit.Assert.assertSame expect the first argument to be the expected value and the second argument to be the actual value. For AssertJ, it’s the other way around, the argument of org.assertj.core.api.Assertions.assertThat is the actual value, and the subsequent calls contain the expected values. Swap them, and your test will still have the same outcome (succeed/fail when it should) but the error messages will be confusing.

Describe the solution you'd like

Swap actual and expected values.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Mar 22, 2023
@Alonexc Alonexc mentioned this issue Mar 22, 2023
Open
@Alonexc Alonexc changed the title [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[ EventMeshServerTest] [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest] Mar 22, 2023
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Mar 28, 2023
monish-byte added a commit to monish-byte/eventmesh that referenced this issue Apr 1, 2023
@monish-byte
issue apache#3520 , swapped the values
bae6741
@mxsm mxsm mentioned this issue Apr 1, 2023
Closed
@garimellasrisudha
Copy link

Hi Alonexc,
is it still available?

@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 10, 2023 •
edited
Loading

@garimellasrisudha Someone has already submitted a pr for this issue, are you interested in other issues?

@Ricky-Qu Ricky-Qu mentioned this issue Oct 14, 2023
Merged
mxsm pushed a commit that referenced this issue Oct 15, 2023
@Ricky-Qu
[ISSUE #3520]Swap these 2 arguments so they are in the correct order…
093fb6b 
…: expected value, actual value.[EventMeshServerTest] (#4486)

* Swap these 2 arguments so they are in the correct order: expected value, actual value.[EventMeshServerTest]

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
3 participants
@xwm1992 @garimellasrisudha @Alonexc