[ISSUE #3963] Method invocation 'getBytes' may produce 'NullPointerException'. #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alonexc
reviewed
May 19, 2023
| @@ -60,7 +61,7 @@ public void handle(HttpExchange httpExchange) throws IOException { | |||
|
|
|||
| try (OutputStream out = httpExchange.getResponseBody()) { | |||
| WebHookConfig result = operation.queryWebHookConfigById(webHookConfig); // operating result | |||
| out.write(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET)); | |||
| out.write(Objects.requireNonNull(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET))); | |||
There was a problem hiding this comment.
I think this should be done:
out.write(Objects.requireNonNull(JsonUtils.toJSONString(result)).getBytes(Constants.DEFAULT_CHARSET));
Alonexc
reviewed
May 19, 2023
| @@ -73,7 +73,7 @@ public void handle(HttpExchange httpExchange) throws IOException { | |||
|
|
|||
| try (OutputStream out = httpExchange.getResponseBody()) { | |||
| List<WebHookConfig> result = operation.queryWebHookConfigByManufacturer(webHookConfig, pageNum, pageSize); // operating result | |||
| out.write(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET)); | |||
| out.write(Objects.requireNonNull(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET))); | |||
|
@ZahaanMahajan you can merge the latest master branch code to fix the ci check error. |
|
I didn't get you. How to do that? |
pull apache:master to your local branch and push it to your remote master branch. |
Codecov Report
@@ Coverage Diff @@
## master #3971 +/- ##
=========================================
Coverage 14.25% 14.25%
Complexity 1320 1320
=========================================
Files 579 579
Lines 28943 28943
Branches 2794 2794
=========================================
Hits 4125 4125
Misses 24426 24426
Partials 392 392
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
May 29, 2023
Alonexc
approved these changes
May 30, 2023
lrhkobe
approved these changes
May 30, 2023
mxsm
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963
Method invocation 'getBytes' may produce 'NullPointerException'.
In the modified code, Objects.requireNonNull() is applied to the return value of JsonUtils.toJSONString(result). If the result is null, a NullPointerException will be thrown immediately, preventing the subsequent invocation of getBytes().
By using Objects.requireNonNull(), it explicitly check for nullness and handle it in a more controlled manner, ensuring that it don't encounter unexpected null values during the execution of the code.