Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method invocation 'getBytes' may produce 'NullPointerException'. #3963

Closed
1 of 2 tasks
Alonexc opened this issue May 18, 2023 · 0 comments · Fixed by #3971
Closed
1 of 2 tasks

[Enhancement] Method invocation 'getBytes' may produce 'NullPointerException'. #3963

Alonexc opened this issue May 18, 2023 · 0 comments · Fixed by #3971
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 18, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/QueryWebHookConfigByIdHandler.java line 63
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/QueryWebHookConfigByManufacturerHandler.java line 76

Describe the solution you'd like

Use Objects.requireNonNull() to avoid NPE.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label May 18, 2023
@Alonexc Alonexc mentioned this issue May 18, 2023
Open
ZahaanMahajan added a commit to ZahaanMahajan/eventmesh that referenced this issue May 19, 2023
@ZahaanMahajan
fixes [Enhancement] apache#3963
48fc238
@ZahaanMahajan ZahaanMahajan mentioned this issue May 19, 2023
Merged
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label May 22, 2023
xwm1992 added a commit that referenced this issue May 31, 2023
@ZahaanMahajan @xwm1992
[ISSUE #3963] Method invocation 'getBytes' may produce 'NullPointerEx…
c5f3aba 
…ception'. (#3971)

* fixes [Enhancement] #3963

* Fix Updated

* Update QueryWebHookConfigByIdHandler.java

---------

Co-authored-by: mike_xwm <mike_xwm@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
2 participants
@xwm1992 @Alonexc