Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3963] Method invocation 'getBytes' may produce 'NullPointerException'. #3971

Merged
merged 4 commits into from
May 31, 2023
Merged

[ISSUE #3963] Method invocation 'getBytes' may produce 'NullPointerException'. #3971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48fc238
fixes [Enhancement] #3963
ZahaanMahajan May 19, 2023
7c8e3ac
Fix Updated
ZahaanMahajan May 19, 2023
3a09c74
Update QueryWebHookConfigByIdHandler.java
xwm1992 May 22, 2023
840ccfb
Merge branch 'apache:master' into master
ZahaanMahajan May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/main/java/org/apache/eventmesh/runtime/admin/handler/QueryWebHookConfigByIdHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import java.io.IOException;
import java.io.OutputStream;

import java.util.Objects;

import com.sun.net.httpserver.HttpExchange;

Expand Down Expand Up @@ -60,7 +60,7 @@ public void handle(HttpExchange httpExchange) throws IOException {

try (OutputStream out = httpExchange.getResponseBody()) {
WebHookConfig result = operation.queryWebHookConfigById(webHookConfig); // operating result
out.write(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET));
out.write(Objects.requireNonNull(JsonUtils.toJSONString(result)).getBytes(Constants.DEFAULT_CHARSET));
} catch (Exception e) {
log.error("get WebHookConfigOperation implementation Failed.", e);
}
Expand Down
2 changes: 1 addition & 1 deletion ...a/org/apache/eventmesh/runtime/admin/handler/QueryWebHookConfigByManufacturerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public void handle(HttpExchange httpExchange) throws IOException {

try (OutputStream out = httpExchange.getResponseBody()) {
List<WebHookConfig> result = operation.queryWebHookConfigByManufacturer(webHookConfig, pageNum, pageSize); // operating result
out.write(JsonUtils.toJSONString(result).getBytes(Constants.DEFAULT_CHARSET));
out.write(Objects.requireNonNull(JsonUtils.toJSONString(result)).getBytes(Constants.DEFAULT_CHARSET));
} catch (Exception e) {
log.error("get WebHookConfigOperation implementation Failed.", e);
}
Expand Down