-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from zdesk to zenpy in ZendeskHook #21349
Conversation
f89cb30
to
e2e031c
Compare
e2e031c
to
b012842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over all LGTM
left some comments to address
@eladkal Thank you for your review. I updated the PR accordingly and added the For now the hook is just a wrapper around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one little comment
after that we are good to merge
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
You should also update provider.yaml for zendesk to set the 3.0.0 version :). |
@potiuk thank you, I just updated it :) |
Just docker-tests failing (which we need to fix). merging. |
thanks @pierrejeambrun ! |
closes: #8937
This pull request changes
ZendeskHook
to usezenpy
package instead ofzdesk
.I tried to introduce as little breaking changes as possible. We keep the ability to make 'custom' get request via the
call
method.Starting from here we can then add specific methods for each resource using dedicated zenpy APIs. (accessible trough zenpy's client e.g: users, tickets, organizations etc.). But I think this goes beyond the scope of this PR.
Let me know what you think.