Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change from zdesk to zenpy in ZendeskHook #8937

Closed
RosterIn opened this issue May 20, 2020 · 11 comments · Fixed by #21349
Closed

change from zdesk to zenpy in ZendeskHook #8937

RosterIn opened this issue May 20, 2020 · 11 comments · Fixed by #21349

Comments

@RosterIn
Copy link
Contributor

RosterIn commented May 20, 2020

Description
zdesk hasn't been updated in two years.
there is a better maintained package zenpy

The ZendeskHook needs to be refactored to work with the new package.

@xrmx
Copy link

xrmx commented Oct 6, 2020

Looking at the zenpy code it looks like that every endpoint is wrapped in a class, see https://github.com/facetoe/zenpy/blob/master/zenpy/__init__.py#L97. Can't see a sane way to map the plain path to a class to keep backwards compatibility. Said that we can leverage the BaseApi class in https://github.com/facetoe/zenpy/blob/master/zenpy/lib/api.py to get ratelimit handling for free. Do you have any thoughts?

@RosterIn
Copy link
Contributor Author

RosterIn commented Oct 8, 2020

@xrmx Since the old package isn't maintained and can't have new functionality I think this change is required even if breaking change. Also Airflow soon change major version which is great because it will be able to introduce breaking changes.
I think better to hear from the project owners @potiuk @kaxil @mik-laj

@kaxil
Copy link
Member

kaxil commented Oct 8, 2020

Yes I agree, let's use zenpy since zdesk seems to be abandoned.

@eladkal
Copy link
Contributor

eladkal commented Nov 8, 2020

@xrmx do you want to work on this task?

@xrmx
Copy link

xrmx commented Nov 8, 2020

@eladkal nope

@ghost
Copy link

ghost commented Nov 10, 2020

I'll give this a shot!

@mik-laj mik-laj assigned ghost Nov 11, 2020
@mik-laj
Copy link
Member

mik-laj commented Nov 11, 2020

I assigned you to this ticket.

@pierrejeambrun
Copy link
Member

Hi,

I can work on this one :)

@uranusjr
Copy link
Member

Go ahead

@eladkal
Copy link
Contributor

eladkal commented Jan 31, 2022

@pierrejeambrun are you still working on this issue?

@pierrejeambrun
Copy link
Member

Hello @eladkal

I didn't start yet, I wanted to close this one first #20386 but it's taking a little longer than expected. I think it's ready now and I can start working on this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants