Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on February 09, 2022 #21443

Closed
44 of 74 tasks
potiuk opened this issue Feb 8, 2022 · 32 comments
Closed
44 of 74 tasks

Status of testing Providers that were prepared on February 09, 2022 #21443

potiuk opened this issue Feb 8, 2022 · 32 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@potiuk
Copy link
Member

potiuk commented Feb 8, 2022

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 3.0.0rc2

Provider apache.druid: 2.3.0rc2

Provider apache.hive: 2.2.0rc2

Provider apache.spark: 2.1.0rc2

Provider apache.sqoop: 2.1.0rc2

Provider cncf.kubernetes: 3.0.2rc2

Provider docker: 2.4.1rc2

Provider exasol: 2.1.0rc2

Provider google: 6.4.0rc2

Provider http: 2.0.3rc2

Provider imap: 2.2.0rc2

Provider jdbc: 2.1.0rc2

Provider microsoft.azure: 3.6.0rc2

Provider microsoft.mssql: 2.1.0rc2

Provider microsoft.psrp: 1.1.0rc2

Provider mysql: 2.2.0rc2

Provider oracle: 2.2.0rc2

Provider postgres: 3.0.0rc2

Provider qubole: 2.1.0rc2

Provider slack: 4.2.0rc2

Provider snowflake: 2.5.0rc2

Provider sqlite: 2.1.0rc2

Provider ssh: 2.4.0rc2

Provider tableau: 2.1.4rc2

Provider vertica: 2.1.0rc2

Provider zendesk: 3.0.0rc2

@potiuk potiuk added the kind:meta High-level information important to the community label Feb 8, 2022
@david30907d
Copy link
Contributor

sure, will test it on weekend

@frankcash
Copy link
Contributor

I was able to verify #21427 has been resolved in this RC

@mariotaddeucci
Copy link
Contributor

#20807 all good o/

@dstandish
Copy link
Contributor

@potiuk any reason elasticsearch not included?
there was this change: #21261
too late i guess?

@potiuk
Copy link
Member Author

potiuk commented Feb 9, 2022

@potiuk any reason elasticsearch not included? there was this change: #21261 too late i guess?

AAAAH good eye @dstandish. Thanks!

This one was actually a mistake of mine. I classified as "doc-only" change in RC1 (the only change was that it had :rtype removed from the docs). That triggered a mistake when I released an RC2 - because I re-classified it the same (but there were your changes merged since).

I will continue with the release and wil re-release it after this voting (I will also take a look if I had not made similar RC1-> RC2 mistake).

@dstandish
Copy link
Contributor

really it's @jedcunningham's eyes that are due any credit

but thank you very much @potiuk

@pierrejeambrun
Copy link
Member

Hi,

I tested all the methods for the new ZendeskHook, everything is working fine.

#21349 ✔️

@potiuk
Copy link
Member Author

potiuk commented Feb 10, 2022

Cool. Loooking forward for more comments. We have time till ~ end of weekend (I will release on Sunday/Monday morning if I get enough votes)

@kazanzhy
Copy link
Contributor

Changes in Qubole provider was in documentation (#20058) and typing (#21074).
There are no code changes, therefore I'm pretty sure everything is OK.

@derkuci
Copy link
Contributor

derkuci commented Feb 11, 2022

#20474 has been running in our system without issues.

@eladkal
Copy link
Contributor

eladkal commented Feb 11, 2022

@potiuk why the new GitHub provider is missing?
#21076

@SasanAhmadi
Copy link
Contributor

@potiuk, I checked #21277 has been resolved in this RC.

@MaksYermak
Copy link
Contributor

@potiuk I´ve checked #20981 and #21253 it works fine

@raphaelauv
Copy link
Contributor

docker: 2.4.1rc2 is working correctly 👍

Screenshot from 2022-02-11 11-48-52

@nshetty15
Copy link
Contributor

@potiuk #19981 is working fine without issues.

@potiuk
Copy link
Member Author

potiuk commented Feb 11, 2022

@potiuk why the new GitHub provider is missing? #21076

Becasue there is really nothing to test there ;) . If there is an error there, it's not a regression :). But seriously - we also release GitHub one, it's just not added to the list here...

But srsly: @pateash if you could test this as well it would be awesome: https://pypi.org/project/apache-airflow-providers-github/1.0.0rc2/

Thanks @eladkal for vigilance!

@pateash
Copy link
Contributor

pateash commented Feb 11, 2022

@potiuk why the new GitHub provider is missing? #21076

Becasue there is really nothing to test there ;) . If there is an error there, it's not a regression :). But seriously - we also release GitHub one, it's just not added to the list here...

But srsly: @pateash if you could test this as well it would be awesome: https://pypi.org/project/apache-airflow-providers-github/1.0.0rc2/

Sure @potiuk, let me look into it.

@mehmax
Copy link
Contributor

mehmax commented Feb 11, 2022

Hi @potiuk
I tested #19084 in our environment. In some cases the backwards compatibility is not sufficient.
Improvement see PR #21524

@josh-fell
Copy link
Contributor

#21195, #21285, and #21403 Look good

#21237 Looks good except for an inconsequential typo in the template_fields_renderers dict for HiveOperator in the Apache Hive provider.

TIL that the logic which chooses the renderer will, cleverly, default to the template field name if it cannot find said template field in the template_fields_renderers dict. For HiveOperator the key in template_fields_renderers is "sql" when it should be "hql". Luckily "hql" is itself a renderer so there is no impact on the visual rendering in the UI. @potiuk I created #21525 to fix the typo.

@potiuk
Copy link
Member Author

potiuk commented Feb 11, 2022

I tested #19084 in our environment. In some cases the backwards compatibility is not sufficient.
Improvement see PR #21524

Cool. Will release it with elasticsearch as RC3 then (the longest Provider release ever :) )

@potiuk
Copy link
Member Author

potiuk commented Feb 11, 2022

Tested:

image

Both #14489 and #21262 with SSH (both banner timeout and retry present in the log):

[2022-02-11, 19:23:10 UTC] {transport.py:1873} ERROR - Exception (client): Error reading SSH protocol banner
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - Traceback (most recent call last):
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -   File "/usr/local/lib/python3.7/site-packages/paramiko/transport.py", line 2270, in _check_banner
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -     buf = self.packetizer.readline(timeout)
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -   File "/usr/local/lib/python3.7/site-packages/paramiko/packet.py", line 380, in readline
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -     buf += self._read_timeout(timeout)
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -   File "/usr/local/lib/python3.7/site-packages/paramiko/packet.py", line 622, in _read_timeout
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -     raise socket.timeout()
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - socket.timeout
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - 
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - During handling of the above exception, another exception occurred:
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - 
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - Traceback (most recent call last):
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -   File "/usr/local/lib/python3.7/site-packages/paramiko/transport.py", line 2093, in run
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -     self._check_banner()
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -   File "/usr/local/lib/python3.7/site-packages/paramiko/transport.py", line 2275, in _check_banner
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR -     "Error reading SSH protocol banner" + str(e)
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - paramiko.ssh_exception.SSHException: Error reading SSH protocol banner
[2022-02-11, 19:23:10 UTC] {transport.py:1871} ERROR - 
[2022-02-11, 19:23:10 UTC] {ssh.py:314} INFO - Failed to connect. Sleeping before retry attempt 1
[2022-02-11, 19:23:14 UTC] {ssh.py:314} INFO - Failed to connect. Sleeping before retry attempt 2

@subkanthi
Copy link
Contributor

#21199 is only a documentation change and I see the change in the tag.

@potiuk
Copy link
Member Author

potiuk commented Feb 12, 2022

Still some chances for testing as we are waiting for votes. So feel free :)

@pateash
Copy link
Contributor

pateash commented Feb 12, 2022

Hi @potiuk @eladkal ,

apache-airflow-provider-github v1.0.0rc2 working as expected, I have validated against airflow v2.2.3

image

@potiuk
Copy link
Member Author

potiuk commented Feb 12, 2022

Cool!

@david30907d
Copy link
Contributor

#19008 has a bug, my bad 😅
already sent a PR and hope I can pass the CI #21542

@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2022

#19008 has a bug, my bad sweat_smile already sent a PR and hope I can pass the CI #21542

Ah . Cool that you checked. I will exclude trino from the release too and release those (and rc3 will include trino as well).

@eladkal
Copy link
Contributor

eladkal commented Feb 13, 2022

Ah . Cool that you checked. I will exclude trino from the release too and release those (and rc3 will include trino as well).

I think @david30907d meant #19508 not #19008.
its about google provider not trino

@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2022

Ah . Cool that you checked. I will exclude trino from the release too and release those (and rc3 will include trino as well).

I think @david30907d meant #19508 not #19008. its about google provider not trino

Yeah. I realized it when approved it :)

@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2022

Glad that you checked @eladkal :)

@david30907d
Copy link
Contributor

Oh sorry i have fat-fingers 😅

@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2022

Thanks for testing. All providers except oracle, elasticsearch, google from that batch have been released. Proceeding with rc3 for the three.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests