Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudsql import links fix. #21199

Merged
merged 48 commits into from
Jan 28, 2022
Merged

Conversation

subkanthi
Copy link
Contributor

Small fix for cloudsql import links


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

subkanthi and others added 30 commits November 22, 2021 13:36
@subkanthi subkanthi requested a review from turbaszek as a code owner January 28, 2022 22:43
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 28, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 28, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@jedcunningham
Copy link
Member

Static check failures are unrelated and will be fixed in #21203.

@jedcunningham jedcunningham merged commit 48d44b8 into apache:main Jan 28, 2022
@jedcunningham
Copy link
Member

@subkanthi, not a big deal, but could you maybe do a reset on your base branch in your fork/local? You end up adding a ton of commits to all your PRs, and it just adds noise to us reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants