Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Create CustomJob and Datasets operators for Vertex AI service (#20077)" #21203

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Revert "Create CustomJob and Datasets operators for Vertex AI service (#20077)" #21203

merged 1 commit into from
Jan 29, 2022

Conversation

jedcunningham
Copy link
Member

This reverts commit 640c0b6.

#20077 is breaking main with a bunch of mypy failures. e.g: https://github.com/apache/airflow/runs/4987359162?check_suite_focus=true

@jedcunningham jedcunningham mentioned this pull request Jan 28, 2022
Merged
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 29, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@jedcunningham
Copy link
Member Author

The test failures are unrelated - they were failing before #20077 was merged too - but static checks are passing now.

@jedcunningham jedcunningham merged commit 1d4b709 into apache:main Jan 29, 2022
@jedcunningham jedcunningham deleted the revert_20077 branch January 29, 2022 00:43
@jedcunningham jedcunningham mentioned this pull request Jan 29, 2022
Merged
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@turbaszek turbaszek Awaiting requested review from turbaszek

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees
No one assigned
Labels
area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedcunningham @mik-laj