[Oracle] Oracle Hook - automatically set current_schema when defined in Connection

[mehmax]

Per Default, Oracle Hook was using "scheme" field of the Connection only when generating DSN uri.

This PR adds functionality to Oracle Hook.
-> When a schema is provided in the Connection Parameters (maintained in the UI), then this schema is set as current_schema after connecting to the Database

This allows SQLs to be less static.

Before:
SELECT * FROM PROD_SCHEMA.MY_TABLE
SELECT * FROM TEST_SCHEMA.MY_TABLE

Now:
SELECT * FROM MY_TABLE

closes: #18664
^ Add meaningful description above

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[uranusjr]

Sorry for missing this. This is close to ready IMO so let’s get it finished.

[uranusjr]

The linter is complaining.

[potiuk]

Yeah . I am really just about to release (slightly delayed) provider's release so it would be great to get that one ien @mehmax

[mehmax]

The linter is complaining.

Should be fixed now. Sorry

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[potiuk]

Just a docker-compose failure which we will fix shorlty.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[malthe]

@potiuk this seems to have broken something in our system – just letting you know for release purposes while I investigate.

[malthe]

This seems to have been fixed in #21524 but I wonder if this was intentional in the sense that the None vs empty string situation was just resolved by chance.

[potiuk]

This seems to have been fixed in #21524 but I wonder if this was intentional in the sense that the None vs empty string situation was just resolved by chance.

This was the reason why I "held" the RC2 version for Oracle provider - and yeah, I believe @mehmax found the same compatibility provlem and fixed it (included in RC3). Any more comments @malthe about your error to verify it was the same issue?

[mehmax]

Hi @malthe,
If you were passing the Service Name in the conn.schema field, the this PR might have had negative impact.

With fix in #21524 I not only changed this from a None to an empty string check, but also added conn.extra["service_name"] / service_name to the check

[malthe]

@mehmax I had a conn.schema which was an empty string so I needed the #21524 behavior there as well. I can confirm that rc3 works for me.