-
-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commits count when include_all_commits is true #391
Conversation
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 94.37% 94.35% -0.03%
==========================================
Files 16 16
Lines 516 514 -2
Branches 140 140
==========================================
- Hits 487 485 -2
Misses 25 25
Partials 4 4
Continue to review full report at Codecov.
|
It's strange that the total commits returned by the experimental API are only 2.9k when there are 3.3k in the last year according to the GraphQL API.... Maybe the experimental API only counts public commits ? 🧐 |
Of course how would we even access the private commits. |
You're right, but I wonder if you could access your private commits when deploying your own instance with your own PAT.. |
So is it OK to merge? Or do you want me to edit something? |
Hello ? |
Hey @bokub really sorry for the late response, i totally forgot about this PR. this looks good to me! Thanks for the fix! |
No problem, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you guys think that the API merge may have access to the private commits or what?
any idea why this shows more number of total commits in 2020 than total commits in all time? |
The
totalCommitsFetcher
already sends the total number of commits, we don't need to add the values returned by the GraphQL APIFixes #298
Current master:
My fork: