Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commits count when include_all_commits is true #391

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Fix commits count when include_all_commits is true #391

merged 1 commit into from
Sep 24, 2020

Conversation

bokub
Copy link
Contributor

@bokub bokub commented Aug 15, 2020

The totalCommitsFetcher already sends the total number of commits, we don't need to add the values returned by the GraphQL API

Fixes #298

Current master:

Minji's Stats
Minji's Stats

My fork:

Minji's Stats
Minji's Stats

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #391 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   94.37%   94.35%   -0.03%     
==========================================
  Files          16       16              
  Lines         516      514       -2     
  Branches      140      140              
==========================================
- Hits          487      485       -2     
  Misses         25       25              
  Partials        4        4              
Impacted Files Coverage Δ
src/fetchers/stats-fetcher.js 91.11% <100.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9937aca...3f93846. Read the comment docs.

@bokub
Copy link
Contributor Author

bokub commented Aug 15, 2020

It's strange that the total commits returned by the experimental API are only 2.9k when there are 3.3k in the last year according to the GraphQL API....

Maybe the experimental API only counts public commits ? 🧐

@anuraghazra
Copy link
Owner

Maybe the experimental API only counts public commits ? monocle_face

Of course how would we even access the private commits.

@anuraghazra anuraghazra added the bug Something isn't working. label Aug 16, 2020
@bokub
Copy link
Contributor Author

bokub commented Aug 16, 2020

Of course how would we even access the private commits.

You're right, but I wonder if you could access your private commits when deploying your own instance with your own PAT..

@bokub
Copy link
Contributor Author

bokub commented Aug 16, 2020

So is it OK to merge? Or do you want me to edit something?

@bokub
Copy link
Contributor Author

bokub commented Aug 26, 2020

Hello ?

@anuraghazra
Copy link
Owner

Hey @bokub really sorry for the late response, i totally forgot about this PR. this looks good to me! Thanks for the fix!

@anuraghazra anuraghazra merged commit 851bb7b into anuraghazra:master Sep 24, 2020
@bokub
Copy link
Contributor Author

bokub commented Sep 24, 2020

No problem, thanks!

Copy link

@elfalehed elfalehed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you guys think that the API merge may have access to the private commits or what?

@techno-disaster
Copy link

The totalCommitsFetcher already sends the total number of commits, we don't need to add the values returned by the GraphQL API

Fixes #298

Current master:

Minji's Stats
Minji's Stats

My fork:

Minji's Stats
Minji's Stats

any idea why this shows more number of total commits in 2020 than total commits in all time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total Commits number error
4 participants