Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total Commits number error #298

Closed
minji-o-j opened this issue Aug 2, 2020 · 1 comment · Fixed by #391
Closed

Total Commits number error #298

minji-o-j opened this issue Aug 2, 2020 · 1 comment · Fixed by #391
Labels
bug Something isn't working.

Comments

@minji-o-j
Copy link

minji-o-j commented Aug 2, 2020 •
edited
Loading

Describe the bug
Total Commits "include_all_commits=true" error

Expected behavior
image
image
image

I expected 3.2k, but the live demo counted 6k...

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)
If applicable, add screenshots to help explain your problem.

Minji's Stats

![Minji's Stats](https://github-readme-stats.vercel.app/api?username=minji-o-j&hide=stars&hide_title=true&show_icons=true&icon_color=333&title_color=333&text_color=777&count_private=true&include_all_commits=true)

And when I changed like that include_all_commits=false, the counter counted my total Commits.

Minji's Stats

![Minji's Stats](https://github-readme-stats.vercel.app/api?username=minji-o-j&hide=stars&hide_title=true&show_icons=true&icon_color=333&title_color=333&text_color=777&count_private=true&include_all_commits=false)
@anuraghazra
Copy link
Owner

Hi @minji-o-j thanks for reporting the issue, yeah it seems like we are currently adding the private commits + public commits which is causing the commits to be larger than expected. will fix it.

@anuraghazra anuraghazra added the bug Something isn't working. label Aug 8, 2020
@anuraghazra anuraghazra mentioned this issue Aug 14, 2020
Merged
@bokub bokub mentioned this issue Aug 15, 2020
Merged
mochoy added a commit to mochoy/mochoy that referenced this issue Sep 8, 2020
@mochoy
Use total commits, not just 2020 commits in gh stats
e795e9e 
total commits current has a bug where it's not properly counting commits, but it gives me a better rating lmao. Hoping for fix soon: 
anuraghazra/github-readme-stats#211
anuraghazra/github-readme-stats#298
@anuraghazra anuraghazra mentioned this issue Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix commits count when include_all_commits is true
2 participants
@anuraghazra @minji-o-j