fix: wip fix total commit counts

[anuraghazra]

fixes #14
fixes #92
closes #15

Currently github readme stats can only fetch total commits of 1year max, because of limitations of Github API mentioned in here #14 (comment) but we can fix it by brute forcing and looping over all the years to accumulate total commits of a user as we did in #15

But there are downsides of this approach in terms on performance because we are looping over all the years and calling the GraphQL Api each time

The fix

So as mentioned by @kingthorin in this comment #15 (comment) instead of showing "Total commits" we would show "Total Commits (2020)" in order to eliminate any confusion.

And as mentioned in this #92 (comment) by @adamyi Github has a experimental REST endpoint to fetch all the commits which we can utilize nicely.

We've added a new flag "include_all_commits" which would fetch the total commits of a user if enabled otherwise we will show only the last year commits (which is current behaviour)

Screenshots

@rampatra issue #92

• &include_all_commits=true
  

• &include_all_commits=false
  

@anshumanv issue #14

• &include_all_commits=true

• &include_all_commits=false
  

NOTE: As mentioned in github's documentation https://developer.github.com/v3/search/#search-commits this API is experimental and the API may change without advance notice during the preview period.

TODO:

• Write tests
• Discussion

[codecov]

Codecov Report

Merging #211 into master will decrease coverage by 0.57%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   94.86%   94.28%   -0.58%     
==========================================
  Files          16       16              
  Lines         467      490      +23     
  Branches      123      130       +7     
==========================================
+ Hits          443      462      +19     
- Misses         20       24       +4     
  Partials        4        4              

Impacted Files	Coverage Δ
src/fetchStats.js	91.30% <81.81%> (-8.70%)	⬇️
api/index.js	100.00% <100.00%> (ø)
src/renderStatsCard.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4486d0...ff292f2. Read the comment docs.

[rampatra]

I think when &include_all_commits=true the year shouldn't be there in the title Total Commits (2020). It should be just Total Commits.

[anshumanv]

Doesn't show up in mine for some reason

[anuraghazra]

I think when &include_all_commits=true the year shouldn't be there in the title Total Commits (2020). It should be just Total Commits.

Oh weird, maybe i uploaded the wrong screenshot. my bad

[anuraghazra]

Live demo

include_all_commits=false

include_all_commits=true

include_all_commits=false

include_all_commits=true

[masterking32]

Hey @anuraghazra , thanks, Can we have both of them? like this
Total commits: XXX
2020 Commits: XXX

[anuraghazra]

Hey @anuraghazra , thanks, Can we have both of them? like this
Total commits: XXX
2020 Commits: XXX

Good idea, but i'm not sure i would do that, it seems kinda redundant.

[bokub]

Just to be sure about this code:

github-readme-stats/src/fetchStats.js

Lines 121 to 126 in ff292f2

	stats.totalCommits =
	contributionCount.totalCommitContributions + experimental_totalCommits;
	if (count_private) {
	stats.totalCommits += contributionCount.restrictedContributionsCount;
	}

I though experimental_totalCommits already contained all the commits, but you're adding the totalCommitContributions and the restrictedContributionsCount from the GraphQL API.

Aren't you counting the same commits 2 times ?

[anuraghazra]

Just to be sure about this code:

github-readme-stats/src/fetchStats.js

Lines 121 to 126 in ff292f2

	stats.totalCommits =
	contributionCount.totalCommitContributions + experimental_totalCommits;
	if (count_private) {
	stats.totalCommits += contributionCount.restrictedContributionsCount;
	}

I though experimental_totalCommits already contained all the commits, but you're adding the totalCommitContributions and the restrictedContributionsCount from the GraphQL API.

Aren't you counting the same commits 2 times ?

#298 feel free to send a PR

[bokub]

Sure! I will try to send a PR this weekend if I find some time

Edit: see #391