Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding intersphinx links #54

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 7, 2022

Following the release of antsibull-docs 1.7.0 we now have access to --intersphinx when initializing sphinx.
ansible-community/antsibull-docs#44

This means that we can automatically generate links between multiple docs sites

@tremble
Copy link
Contributor Author

tremble commented Oct 7, 2022

@tremble
Copy link
Contributor Author

tremble commented Oct 7, 2022

@briantist @felixfontein

@felixfontein
Copy link
Collaborator

The CI errors should go away once #55 is merged.

Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for submitting this! If possible I'd really like to see some tests, if only for the action which has a set of tests already.

@tremble tremble force-pushed the intersphinx-links branch 2 times, most recently from 28418d5 to 87d9d54 Compare October 8, 2022 19:39
@tremble tremble force-pushed the intersphinx-links branch from 87d9d54 to 8ad4eb0 Compare October 8, 2022 19:49
@tremble tremble force-pushed the intersphinx-links branch from 8ad4eb0 to d7d971d Compare October 8, 2022 19:52
@tremble
Copy link
Contributor Author

tremble commented Oct 8, 2022

@felixfontein done

@briantist briantist merged commit a30f749 into ansible-community:main Oct 8, 2022
@briantist
Copy link
Collaborator

@tremble thank you for adding this feature!
@felixfontein thank you for reviewing and adding the relevant feature to antsibull-docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants