Update docs workflows to use intersphinx links #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'fake' module links
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 21s |
alinabuzachis
approved these changes
Oct 10, 2022
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 45s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1144 🤖 @patchback |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
fix ecs_cluster integration test SUMMARY ecs_cluster: make ecs_cluster integration test work again - as it is bugs I've hit and must be fixed to complete this challenge ecs_taskdefinition: fix change detection of changing launch_type parameter ecs_service: compare of task_definition never works and results always in a changed task change detect of health_check_grace_period_seconds was never implemented, but tested and failing, after the task_definition is compared correctly ref: ansible-collections#1142 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ecs_service ADDITIONAL INFORMATION basically the existing test tasks are not changed. just sorted and removed what was marked as fixme because it's simple not possible (changing network settings of a created service). Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#1187) ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref ansible-collections#1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
fix ecs_cluster integration test SUMMARY ecs_cluster: make ecs_cluster integration test work again - as it is bugs I've hit and must be fixed to complete this challenge ecs_taskdefinition: fix change detection of changing launch_type parameter ecs_service: compare of task_definition never works and results always in a changed task change detect of health_check_grace_period_seconds was never implemented, but tested and failing, after the task_definition is compared correctly ref: ansible-collections#1142 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ecs_service ADDITIONAL INFORMATION basically the existing test tasks are not changed. just sorted and removed what was marked as fixme because it's simple not possible (changing network settings of a created service). Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#1187) ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref ansible-collections#1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
fix ecs_cluster integration test SUMMARY ecs_cluster: make ecs_cluster integration test work again - as it is bugs I've hit and must be fixed to complete this challenge ecs_taskdefinition: fix change detection of changing launch_type parameter ecs_service: compare of task_definition never works and results always in a changed task change detect of health_check_grace_period_seconds was never implemented, but tested and failing, after the task_definition is compared correctly ref: ansible-collections#1142 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ecs_service ADDITIONAL INFORMATION basically the existing test tasks are not changed. just sorted and removed what was marked as fixme because it's simple not possible (changing network settings of a created service). Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…le-collections#1187) ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref ansible-collections#1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Makes use of ansible-community/github-docs-build#54 to add support for linking between amazon.aws and community.aws GitHub pages documentation.
ISSUE TYPE
COMPONENT NAME
.github
ADDITIONAL INFORMATION