Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add amazon.aws / ansible-core intersphinx links #1554

Merged
merged 1 commit into from
Oct 10, 2022
Merged

add amazon.aws / ansible-core intersphinx links #1554

merged 1 commit into from
Oct 10, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 7, 2022 •
edited
Loading

SUMMARY

Rather than manually maintaining a list of cross-repo links (or waiting for the devel docs to be released) use intersphinx to automatically link between the repos

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

.github/workflows/docs-pr.yml
.github/workflows/docs-push.yml

ADDITIONAL INFORMATION

@tremble tremble mentioned this pull request Oct 7, 2022
Merged
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage labels Oct 7, 2022
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Oct 10, 2022
@tremble tremble requested a review from alinabuzachis October 10, 2022 07:31
@tremble tremble marked this pull request as ready for review October 10, 2022 07:31
@tremble tremble requested a review from felixfontein October 10, 2022 08:14
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 10, 2022
@tremble
Copy link
Contributor Author

tremble commented Oct 10, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 6m 05s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 35s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 06s
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 8m 54s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 07s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 23s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 5m 08s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 30s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 36s
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 8m 34s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 54s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 19s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@tremble tremble merged commit 099b831 into ansible-collections:main Oct 10, 2022
@patchback
Copy link

patchback bot commented Oct 10, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/099b8318d3e2a3d05aa179b0a3669a5ad5250920/pr-1554

Backported as #1556

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 10, 2022
@tremble @patchback
Update docs workflows to use intersphinx links instead of hard coding…
12708c6 
… 'fake' module links (#1554)

(cherry picked from commit 099b831)
@patchback patchback bot mentioned this pull request Oct 10, 2022
Merged
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

tremble added a commit that referenced this pull request Oct 10, 2022
@patchback @tremble
Update docs workflows to use intersphinx links instead of hard coding…
7c371de 
… 'fake' module links (#1554) (#1556)

(cherry picked from commit 099b831)

Co-authored-by: Mark Chappell <mchappel@redhat.com>
@tremble tremble deleted the workflows/intersphinx branch February 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @alinabuzachis @ansibullbot