ec2_eip: apply the tags during the object creation #1505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fe2d35 to
cbdec5f
Compare
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. See: ansible-collections#1495 (comment)
cbdec5f to
784ea45
Compare
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
|
+1 to the change. However the module already moved |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Ensure ec2_instance tests filter correctly SUMMARY Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml ADDITIONAL INFORMATION in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt the Create multiple instance (check_mode) task erroneously picks up instances from the ec2_instance_instance_minimal test target. Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1495
Apply the tags during the Elastic IP creation using
TagSpecifications. This to avoida potential race condition between the moment the object is created and the moment we apply
the tags.
See: #1495 (comment)