Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ec2_eip: ignore existing EIP #1495

Conversation

goneri
Copy link
Member

@goneri goneri commented Sep 17, 2022

Use a tag to dissociate EIPs from the test from the others. This allow
use to the same test several times in parallel.

Use a tag to dissociate EIPs from the test from the others. This allow
use to the same test several times in parallel.
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added integration tests/integration needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) tests tests labels Sep 17, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 45s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 56s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 19s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 33s
✔️ ansible-test-splitter SUCCESS in 3m 29s
✔️ integration-community.aws-1 SUCCESS in 10m 05s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@goneri goneri requested a review from tremble September 18, 2022 00:16
@tremble
Copy link
Contributor

tremble commented Sep 20, 2022

Prior to doing this we probably need to update the module to tag as part of the allocation (using TagSpecifications) rather than tagging after allocation. There are potential race conditions in play.

goneri added a commit to goneri/community.aws that referenced this pull request Sep 20, 2022
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid
a potential race condition between the moment the object is created and the moment we apply
the tags.

Depends-On: ansible-collections#1495

See: ansible-collections#1495 (comment)
goneri added a commit to goneri/community.aws that referenced this pull request Sep 20, 2022
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid
a potential race condition between the moment the object is created and the moment we apply
the tags.

Depends-On: ansible-collections#1495

See: ansible-collections#1495 (comment)
goneri added a commit to goneri/community.aws that referenced this pull request Sep 20, 2022
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid
a potential race condition between the moment the object is created and the moment we apply
the tags.

See: ansible-collections#1495 (comment)
goneri added a commit to goneri/community.aws that referenced this pull request Sep 20, 2022
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid
a potential race condition between the moment the object is created and the moment we apply
the tags.

See: ansible-collections#1495 (comment)
goneri added a commit to goneri/community.aws that referenced this pull request Sep 20, 2022
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid
a potential race condition between the moment the object is created and the moment we apply
the tags.

See: ansible-collections#1495 (comment)
@goneri
Copy link
Member Author

goneri commented Sep 20, 2022

Prior to doing this we probably need to update the module to tag as part of the allocation (using TagSpecifications) rather than tagging after allocation. There are potential race conditions in play.

See: #1505

@alinabuzachis
Copy link
Contributor

@goneri @tremble Since ec2_eip is one if the modules we'd like to promote I guess we need to merge this one first.

@goneri
Copy link
Member Author

goneri commented Sep 21, 2022

@alinabuzachis As you prefer, I don't mind doing a rebase against amazon.aws later.

@tremble
Copy link
Contributor

tremble commented Sep 21, 2022

I'd suggest we merge this in after migrating. Let's try and get the migrations done.

@tremble
Copy link
Contributor

tremble commented Sep 22, 2022

For the sake of not adding blockers to getting the migrations merged, I'll close this out. Goneri already offered to re-open it in amazon.aws once things have moved.

@tremble tremble closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests/integration needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants