-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/ec2_eip: ignore existing EIP #1495
tests/ec2_eip: ignore existing EIP #1495
Conversation
Use a tag to dissociate EIPs from the test from the others. This allow use to the same test several times in parallel.
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
Prior to doing this we probably need to update the module to tag as part of the allocation (using TagSpecifications) rather than tagging after allocation. There are potential race conditions in play. |
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. Depends-On: ansible-collections#1495 See: ansible-collections#1495 (comment)
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. Depends-On: ansible-collections#1495 See: ansible-collections#1495 (comment)
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. See: ansible-collections#1495 (comment)
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. See: ansible-collections#1495 (comment)
Apply the tags during the Elastic IP creation using `TagSpecifications`. This to avoid a potential race condition between the moment the object is created and the moment we apply the tags. See: ansible-collections#1495 (comment)
See: #1505 |
@alinabuzachis As you prefer, I don't mind doing a rebase against amazon.aws later. |
I'd suggest we merge this in after migrating. Let's try and get the migrations done. |
For the sake of not adding blockers to getting the migrations merged, I'll close this out. Goneri already offered to re-open it in amazon.aws once things have moved. |
Use a tag to dissociate EIPs from the test from the others. This allow
use to the same test several times in parallel.