Migrate ec2_eip* modules and tests #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
gravesm
reviewed
Sep 19, 2022
|
recheck |
|
recheck |
abikouo
approved these changes
Sep 21, 2022
|
recheck |
goneri
approved these changes
Sep 21, 2022
|
recheck |
…tions#333) * Explicitly pass the subnet the instance should live on - try to avoid https://github.com/ansible-collections/community.aws/issues/329 * Make sure we delete the Instance (and free the EIP) before we try to drop the IGW * Use IDs when cleaning up EC2 instances This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6c0273b
…passed (ansible-collections#328) * Fix ec2_eip with both instance_id and private_ip_address * Add changelog fragment for the ec2_eip fix This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4d1aa98
…tions#349) * ec2_eip - Formally deprecate the 'instance_id' alias. We've been issuing a warning for a while, formally deprecate it so we can start cleaning up the code. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@384af18
* More aliases cleanup * Mark ec2_classic_lb tests unstable * Add more comments about why tests aren't enabled This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cb55efa
This collection has been operating on Zuul CI for some weeks now This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4e0d83c
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9de2610
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@78fc2db
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@0091444
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@02836f3
Remove deprecated "facts" aliases SUMMARY Modules named "facts.py" that do not return ansible_facts were renamed to "info.py" in 2.9. Remove these aliases now that the deprecation period is over. This PR should be included in 3.0.0 of the collection. ISSUE TYPE Bugfix Pull Request COMPONENT NAME *_facts.py Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@68aaa70
) migrate from ansible.netcommon to ansible.utils SUMMARY This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment) ISSUE TYPE Bugfix Pull Request COMPONENT NAME Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests. ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5e5f754
[Breaking Change] Final removal of original boto SDK SUMMARY Remove old boto based inventory script Clean up requirements Clean up random comments in docs/comments ISSUE TYPE Feature Pull Request COMPONENT NAME scripts/inventory/ec2.py requirements.txt test-requirements.txt tests/integration/requirements.txt tests/unit/requirements.txt ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@00037be
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes ansible-collections#159 Depends-On: ansible-collections#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d0596e3
Integration test dependency cleanup SUMMARY remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test) remove setup_ec2 (no main.yml means it's not doing anything) remove prepare_tests (empty main.yml means it's not doing anything) ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did". Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd12046
ec2_eip - remove wait_timeout SUMMARY Remove the wait_timeout option, it has always been ignored by the module ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ADDITIONAL INFORMATION See also: ansible/ansible#64230 Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9460ca1
…sible-collections#1182) Tagging fragment - Move simplest cases over to the docs fragment. Depends-On: ansible-collections#844 SUMMARY Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME changelogs/fragments/1182-tagging.yml plugins/modules/aws_glue_job.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_secret.py plugins/modules/aws_step_functions_state_machine.py plugins/modules/dynamodb_table.py plugins/modules/ec2_eip.py plugins/modules/ec2_transit_gateway_vpc_attachment.py plugins/modules/ec2_vpc_peer.py plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py plugins/modules/iam_role.py plugins/modules/iam_user.py plugins/modules/networkfirewall.py plugins/modules/networkfirewall_policy.py plugins/modules/networkfirewall_rule_group.py plugins/modules/rds_cluster.py plugins/modules/rds_instance.py plugins/modules/rds_instance_snapshot.py plugins/modules/rds_option_group.py plugins/modules/rds_subnet_group.py plugins/modules/redshift.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b11ffae
3dd7a07 to
1c65199
Compare
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
|
regate |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Sep 22, 2022
Migrate ec2_eip* modules and tests Depends-On: ansible-collections/amazon.aws#1032 Remove ec2_eip* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate ec2_eip* modules and tests Depends-On: ansible-collections#1032 Remove ec2_eip* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate ec2_eip* modules and tests Depends-On: ansible-collections#1032 Remove ec2_eip* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/zuul-config#443
Migrate ec2_eip* modules and tests