lambda - Fix flaky integration tests which assume there are no other functions in the account #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions in the account
1 task
tremble
requested changes
Nov 18, 2022
|
Issue was introduced by ansible-collections/community.aws#1239 - the dict of dicts was deprecated for consistency with other modules. We probably need to do something clever with selectattr :/ |
|
I've changed the tests to use But the assert |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
requested changes
Nov 28, 2022
There was a problem hiding this comment.
I think the "defined" issue you're seeing is caused by testing against lambda_infos_all rather than lambda_infos_query_config
I have a slight preference for using a temporary variable when using something so complex to access a list/dict item, but changing that's certainly not a blocker.
tremble
approved these changes
Nov 29, 2022
|
Thanks for the fix. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1289 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
…functions in the account (#1279) lambda - Fix flaky integration tests which assume there are no other functions in the account SUMMARY The integration tests for lambda assume that there are no other lambdas in the account. So when we index into [0], that's not necessarily the lambda we just created. Note that this fix doesn't work. One of the assertions is failing. TASK [lambda : lambda_info | Assert successfull retrieval of all information 2] *** fatal: [testhost]: FAILED! => { "assertion": "lambda_infos_all.function[lambda_function_name].versions is not defined", "changed": false, "evaluated_to": false, "msg": "Assertion failed" } That attribute is defined. It's a list of 2 versions. I don't know why. I'm just creating this PR anyway, so someone else can pickup where I left off. ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Fixes #1277 Reviewed-by: Mark Chappell <None> Reviewed-by: Matthew Davis <None> (cherry picked from commit 737ee75)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
…functions in the account (#1279) (#1289) [PR #1279/737ee750 backport][stable-5] lambda - Fix flaky integration tests which assume there are no other functions in the account This is a backport of PR #1279 as merged into main (737ee75). SUMMARY The integration tests for lambda assume that there are no other lambdas in the account. So when we index into [0], that's not necessarily the lambda we just created. Note that this fix doesn't work. One of the assertions is failing. TASK [lambda : lambda_info | Assert successfull retrieval of all information 2] *** fatal: [testhost]: FAILED! => { "assertion": "lambda_infos_all.function[lambda_function_name].versions is not defined", "changed": false, "evaluated_to": false, "msg": "Assertion failed" } That attribute is defined. It's a list of 2 versions. I don't know why. I'm just creating this PR anyway, so someone else can pickup where I left off. ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Fixes #1277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The integration tests for lambda assume that there are no other lambdas in the account.
So when we index into
[0], that's not necessarily the lambda we just created.Note that this fix doesn't work. One of the assertions is failing.
That attribute is defined. It's a list of 2 versions. I don't know why.
I'm just creating this PR anyway, so someone else can pickup where I left off.
ISSUE TYPE
COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
Fixes #1277