Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda - Fix flaky integration tests which assume there are no other functions in the account #1279

Merged
merged 4 commits into from
Nov 29, 2022
Merged

lambda - Fix flaky integration tests which assume there are no other functions in the account #1279

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9f08cf
Fix flaky lambda integration tests which assume there are no other fu…
mdavis-xyz Nov 18, 2022
a925ac0
change lambda integration tests to use selectattr instead of deprecat…
mdavis-xyz Nov 28, 2022
25583a3
remove debug statements in lambda integration test
mdavis-xyz Nov 28, 2022
1ba055e
refactor long selectattr var in lambda tests
mdavis-xyz Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1277-lambda-int-test-other-lambdas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- lambda - fix flaky integration test which assumes there are no other lambdas in the account (https://github.com/ansible-collections/amazon.aws/issues/1277)
2 changes: 2 additions & 0 deletions tests/integration/inventory
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[testgroup]
testhost ansible_connection="local" ansible_pipelining="yes" ansible_python_interpreter="/home/matthew/.pyenv/versions/3.10.1/bin/python3.10"
50 changes: 25 additions & 25 deletions tests/integration/targets/lambda/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,49 +315,49 @@
check_mode: yes
vars:
ansible_python_interpreter: '{{ botocore_virtualenv_interpreter }}'
- name: lambda_info | Assert successfull retrieval of all information
- name: lambda_info | Assert successfull retrieval of all information 1
assert:
that:
- lambda_infos_all is not failed
- lambda_infos_all.functions | length > 0
- lambda_infos_all.functions[0].function_name == lambda_function_name
- lambda_infos_all.functions[0].runtime == lambda_python_runtime
- lambda_infos_all.functions[0].description == ""
- lambda_infos_all.functions[0].function_arn is defined
- lambda_infos_all.functions[0].handler == lambda_python_handler
- lambda_infos_all.functions[0].versions is defined
- lambda_infos_all.functions[0].aliases is defined
- lambda_infos_all.functions[0].policy is defined
- lambda_infos_all.functions[0].mappings is defined
- lambda_infos_all.functions[0].tags is defined
- lambda_infos_all.functions[0].architectures == ['arm64']
- lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | length == 1
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).runtime == lambda_python_runtime
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).description == ""
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).function_arn is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).handler == lambda_python_handler
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).versions is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).aliases is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).policy is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).mappings is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).tags is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).architectures == ['arm64']

- name: lambda_info | Ensure default query value is 'config' when function name
omitted
lambda_info:
register: lambda_infos_query_config
check_mode: yes
- name: lambda_info | Assert successfull retrieval of all information
- name: lambda_info | Assert successfull retrieval of all information 2
assert:
that:
- lambda_infos_query_config is not failed
- lambda_infos_query_config.functions | length > 0
- lambda_infos_query_config.functions[0].function_name == lambda_function_name
- lambda_infos_query_config.functions[0].runtime == lambda_python_runtime
- lambda_infos_query_config.functions[0].description == ""
- lambda_infos_query_config.functions[0].function_arn is defined
- lambda_infos_query_config.functions[0].handler == lambda_python_handler
- lambda_infos_query_config.functions[0].versions is not defined
- lambda_infos_query_config.functions[0].aliases is not defined
- lambda_infos_query_config.functions[0].policy is not defined
- lambda_infos_query_config.functions[0].mappings is not defined
- lambda_infos_query_config.functions[0].tags is not defined
- lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | length == 1
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).runtime == lambda_python_runtime
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).description == ""
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).function_arn is defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).handler == lambda_python_handler
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).versions is not defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).aliases is not defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).policy is not defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).mappings is not defined
- (lambda_infos_all.functions | selectattr('function_name', 'eq', lambda_function_name) | first).tags is not defined

- name: lambda_info | Ensure default query value is 'all' when function name specified
lambda_info:
name: '{{ lambda_function_name }}'
register: lambda_infos_query_all
- name: lambda_info | Assert successfull retrieval of all information
- name: lambda_info | Assert successfull retrieval of all information 3
assert:
that:
- lambda_infos_query_all is not failed
Expand Down Expand Up @@ -644,7 +644,7 @@
assert:
that:
- result is not failed

# Test creation with layers
- name: Create temporary directory for testing
tempfile:
Expand Down