[PR #1279/737ee750 backport][stable-5] lambda - Fix flaky integration tests which assume there are no other functions in the account #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions in the account (#1279) lambda - Fix flaky integration tests which assume there are no other functions in the account SUMMARY The integration tests for lambda assume that there are no other lambdas in the account. So when we index into [0], that's not necessarily the lambda we just created. Note that this fix doesn't work. One of the assertions is failing. TASK [lambda : lambda_info | Assert successfull retrieval of all information 2] *** fatal: [testhost]: FAILED! => { "assertion": "lambda_infos_all.function[lambda_function_name].versions is not defined", "changed": false, "evaluated_to": false, "msg": "Assertion failed" } That attribute is defined. It's a list of 2 versions. I don't know why. I'm just creating this PR anyway, so someone else can pickup where I left off. ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Fixes #1277 Reviewed-by: Mark Chappell <None> Reviewed-by: Matthew Davis <None> (cherry picked from commit 737ee75)
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…#1289) Add sanity ignore entries for 5.0.0 deprecations SUMMARY We have a number of deprecated features slated for update/removal in 5.0.0 Add sanity ignore entries for now, these should however be removed prior to release ISSUE TYPE Feature Pull Request COMPONENT NAME tests/sanity/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1279 as merged into main (737ee75).
SUMMARY
The integration tests for lambda assume that there are no other lambdas in the account.
So when we index into
[0], that's not necessarily the lambda we just created.Note that this fix doesn't work. One of the assertions is failing.
That attribute is defined. It's a list of 2 versions. I don't know why.
I'm just creating this PR anyway, so someone else can pickup where I left off.
ISSUE TYPE
COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
Fixes #1277