Add bottom margin to tabs component #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
approved these changes
Jun 28, 2018
NickColley
reviewed
Jun 28, 2018
CHANGELOG.md
Outdated
| @@ -22,6 +22,11 @@ | |||
|
|
|||
| 🔧 Fixes: | |||
|
|
|||
| - Add bottom margin to Tabs component | |||
There was a problem hiding this comment.
I think this is technically a breaking change...?
There was a problem hiding this comment.
I suppose if we have clearly documented that all components have a default margin bottom, and this component does not, it could be considered a fix?
Not sure, @dashouse
added 2 commits
June 28, 2018 14:45
All components (or outer layer components) have @include govuk-responsive-margin(6, "bottom"); applied to them so spacing feels automatic.
467381c to
115e852
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All components (or outer layer components) have
@include govuk-responsive-margin(6, "bottom");applied to them so spacing feels automatic.
Tabs had no margin, so this fixes: #820