Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottom margin to tabs component #841

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Add bottom margin to tabs component #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a45aaca
Add bottom margin to tabs component
Jun 28, 2018
115e852
Document in CHANGELOG
Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,15 @@

🔧 Fixes:

- Use relative line-height
Update typography styles to use relative, unitless line-height
- Use relative line-height
Update typography styles to use relative, unitless line-height
([PR #837](https://github.com/alphagov/govuk-frontend/pull/837))

- Add bottom margin to Tabs component
All components (or outer layer components) have a bottom margin
applied to them so spacing feels automatic.
([PR #841](https://github.com/alphagov/govuk-frontend/pull/841))

- Update Crown copyright link
Update the Crown copyright link on the National Archives so
we don't send users on an unnecessary redirect.
Expand Down
1 change: 1 addition & 0 deletions src/components/tabs/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
@include govuk-font($size: 19);
@include govuk-text-colour;
@include govuk-responsive-margin(1, "top");
@include govuk-responsive-margin(6, "bottom");
}

.govuk-tabs__title {
Expand Down