Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govuk-tabs has no bottom margin #820

Closed
dashouse opened this issue Jun 22, 2018 · 1 comment · Fixed by #841
Closed

govuk-tabs has no bottom margin #820

dashouse opened this issue Jun 22, 2018 · 1 comment · Fixed by #841
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@dashouse
Copy link

All components (or outer layer components) have @include govuk-responsive-margin(6, "bottom"); applied to them so spacing feels automatic.

Tabs has no default spacing so the user will need to manually apply spacing when using this component.

screen shot 2018-06-22 at 10 35 30
@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jun 22, 2018
@dashouse dashouse mentioned this issue Jun 22, 2018
Merged
@dashouse
Copy link
Author

Adding a class to the example in the DS for now, we can swap out after this has been implemented alphagov/govuk-design-system#391

@kr8n3r kr8n3r mentioned this issue Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bottom margin to tabs component alphagov/govuk-frontend
2 participants
@NickColley @dashouse