Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit this page component #2545

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Add exit this page component #2545

merged 2 commits into from
Jun 28, 2023

Conversation

owenatgov
Copy link
Contributor

@owenatgov owenatgov commented Feb 14, 2022 •
edited
Loading

What/Why

Adds the Exit This Page component to GOV.UK Frontend. Details about this component including functionality, history of work and decisions can be found in the epic: alphagov/govuk-design-system#1755

Visuals

Standard view

Large screen:
Screenshot 2023-03-28 at 13 59 20

Small screen:
Screenshot 2023-03-28 at 13 59 44

With indicator light active

Large screen:
Screenshot 2023-03-28 at 14 00 02

Small screen:
Screenshot 2023-03-28 at 14 00 40

Forced colours mode (Windows High Contrast)

Large screen:
Screenshot 2023-03-28 at 14 02 58

Small screen:
Screenshot 2023-03-28 at 14 03 36

Forced colours with indicator light active

Large screen:
Screenshot 2023-03-28 at 14 05 04

Small screen:
Screenshot 2023-03-28 at 14 04 29

Testing

This component has been tested extensively via the following means:

  • user research with users with experience of domestic abuse
  • user research with users with assistive tech needs
  • auditing with disabled users via DAC

Notes

This component has been built across the following pull requests:

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 February 14, 2022 14:13 Inactive
vanitabarrett
vanitabarrett reviewed Feb 14, 2022
View reviewed changes
src/govuk/all.js Outdated Show resolved Hide resolved
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 5f5c771 to bf027d6 Compare March 18, 2022 13:52
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 18, 2022 13:52 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch from bf027d6 to 1026b59 Compare March 18, 2022 14:08
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 18, 2022 14:08 Inactive
This was referenced Mar 22, 2022
Closed
Closed
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 1026b59 to 1fe0643 Compare March 23, 2022 12:19
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 23, 2022 12:19 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 1fe0643 to e242700 Compare March 23, 2022 13:55
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 23, 2022 13:55 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch from e242700 to 4a4e19d Compare March 24, 2022 16:33
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 24, 2022 16:33 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 4a4e19d to 159922e Compare March 24, 2022 17:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 24, 2022 17:44 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 159922e to 9c76fda Compare March 25, 2022 12:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 March 25, 2022 12:29 Inactive
@owenatgov owenatgov force-pushed the hide-this-page-component branch 3 times, most recently from 481c8ae to 8c33c7a Compare April 25, 2022 11:52
@owenatgov owenatgov force-pushed the hide-this-page-component branch 2 times, most recently from 9d2104d to c50989e Compare May 26, 2022 13:45
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 June 28, 2023 16:25 Inactive
@owenatgov owenatgov requested a review from colinrotherham June 28, 2023 16:25
@owenatgov owenatgov force-pushed the hide-this-page-component branch from f89ea31 to d75d577 Compare June 28, 2023 16:31
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 June 28, 2023 16:31 Inactive
@owenatgov owenatgov requested a review from colinrotherham June 28, 2023 16:31
@owenatgov owenatgov force-pushed the hide-this-page-component branch from d75d577 to 5a00538 Compare June 28, 2023 16:42
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 June 28, 2023 16:42 Inactive
@owenatgov owenatgov requested a review from colinrotherham June 28, 2023 16:42
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 5a00538 to 31cd2e7 Compare June 28, 2023 17:03
@owenatgov owenatgov requested a review from colinrotherham June 28, 2023 17:04
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 June 28, 2023 17:04 Inactive
owenatgov added 2 commits June 28, 2023 18:12
@owenatgov
Add exit this page component
80c413b 
Also adds the "exit-this-page-with-skiplink" example

Change shortcut timeout methodology
@owenatgov
Add Child Maintenance full page example
97bd949
@owenatgov owenatgov force-pushed the hide-this-page-component branch from 31cd2e7 to 97bd949 Compare June 28, 2023 17:12
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2545 June 28, 2023 17:12 Inactive
colinrotherham
colinrotherham approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the 500th day, Exit this page was approved ✅

Well done everyone involved

@owenatgov owenatgov merged commit ce9ba14 into support/4.x Jun 28, 2023
@owenatgov owenatgov deleted the hide-this-page-component branch June 28, 2023 17:19
@owenatgov owenatgov mentioned this pull request Jun 29, 2023
Merged
@owenatgov owenatgov mentioned this pull request Jul 11, 2023
Merged
@beclamide beclamide mentioned this pull request Aug 19, 2024
Closed
@beclamide beclamide mentioned this pull request Sep 2, 2024
Open
@AbidemiAdio AbidemiAdio mentioned this pull request Sep 19, 2024
Closed
@GodsonLeigh GodsonLeigh mentioned this pull request Sep 19, 2024
Open
@ajaysoni-cap ajaysoni-cap mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 19, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanitabarrett vanitabarrett vanitabarrett left review comments

@querkmachine querkmachine querkmachine left review comments

@colinrotherham colinrotherham colinrotherham approved these changes

@36degrees 36degrees Awaiting requested review from 36degrees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@owenatgov @querkmachine @36degrees @colinrotherham @vanitabarrett @govuk-design-system-ci