Fix Exit this Page indicator colours not being suitable for hover/focus #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the background-color from the indicator dots, as we want it to use whatever the button background colour is (including when hovering or focused). Changes the indicator dots to use `currentcolor` so that the dots remain visible on the button's focus state. Maintains the explicit colour definitions for IE8 as it doesn't support the `currentcolor` keyword.
36degrees
reviewed
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the background-color from the indicator dot container, as we want it to use whatever the button background colour is, including when hovering or focused.
Changes the indicator dots to use
inherit/currentcolorso that the dots remain visible on the button's focus state. Still maintains the explicit colour definitions for IE8 as it doesn't support thecurrentcolorkeyword.Fixes #3246.