Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full page example demonstrating Exit this Page #2943

Merged

Conversation

owenatgov
Copy link
Contributor

Add a full page example to the review app that demonstrates the use of exit this page. This is a rough version of the proposed EtP pattern that is likely to be shipped with EtP and allows us to effectively test EtP without having to create pre-releases into other prototypes.

Likely to be additionally useful for integration testing later on.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2943 October 25, 2022 18:18 Inactive
@querkmachine
Copy link
Member

Approved on the basis that this matches the example presented in the design system mockup, but I'm not sure if this is the 'ideal' presentation for this page.

Specifically, the button appears too far right-aligned on large enough screens due to not having the inline padding of a surrounding column. However, adding a wrapping column prevents the use of position: sticky. Bit of a catch-22.

@owenatgov owenatgov merged commit 3e93901 into hide-this-page-component Oct 26, 2022
@owenatgov owenatgov deleted the exit-this-page-full-page-example branch October 26, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants