Replace use of title component with heading #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackbot
approved these changes
Feb 26, 2025
The title component has been removed from govuk_publishing_components [1] and thus we need to replace it. The heading component with an xl font-size is functionally equivalent. I applied this by using Ashley's example [2], however I omitted setting a margin_bottom of 8 as that matches the margin already added to `govuk-heading-xl` and rendered identically. In updating the tests I've switched from using a class based selector to using element, h1. I've done this because it seems more semantic to match on the element name since we only expect one h1 per response and don't really mind what class it is in request tests. [1]: alphagov/govuk_publishing_components#4653 [2]: https://github.com/alphagov/collections/pull/3963/files
bd5e0ad to
9e1ae08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title component has been removed from govuk_publishing_components 1 and thus we need to replace it. The heading component with an xl font-size is functionally equivalent.
I applied this by using Ashley's example 2, however I omitted setting a margin_bottom of 8 as that matches the margin already added to
govuk-heading-xland rendered identically.