BREAKING: Remove title component #4653
Merged
+58
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a627ca to
be18c38
Compare
be18c38 to
aef7cda
Compare
aef7cda to
d58d9d7
Compare
d58d9d7 to
de66091
Compare
de66091 to
19513cf
Compare
andysellick
approved these changes
Feb 26, 2025
- Removes the title component, as we now use the heading component where titles are needed. - Also replaces gem-c-title references with gem-c-heading in the inverse_header and select component - Also replaces references to the title component in spec files so that tests pass
19513cf to
3dfb20e
Compare
Merged
kevindew
added a commit
to alphagov/govuk-chat
that referenced
this pull request
Feb 26, 2025
The title component has been removed from govuk_publishing_components [1] and thus we need to replace it. The heading component with an xl font-size is functionally equivalent. I applied this by using Ashley's example [2], however I omitted setting a margin_bottom of 8 as that matches the margin already added to `govuk-heading-xl` and rendered identically. [1]: alphagov/govuk_publishing_components#4653 [2]: https://github.com/alphagov/collections/pull/3963/files
kevindew
added a commit
to alphagov/govuk-chat
that referenced
this pull request
Feb 26, 2025
The title component has been removed from govuk_publishing_components [1] and thus we need to replace it. The heading component with an xl font-size is functionally equivalent. I applied this by using Ashley's example [2], however I omitted setting a margin_bottom of 8 as that matches the margin already added to `govuk-heading-xl` and rendered identically. In updating the tests I've switched from using a class based selector to using element, h1. I've done this because it seems more semantic to match on the element name since we only expect one h1 per response and don't really mind what class it is in request tests. [1]: alphagov/govuk_publishing_components#4653 [2]: https://github.com/alphagov/collections/pull/3963/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
titlecomponent, as we are now using theheadingcomponent to provide titles for pages.govuk-chatand DGU, butgovuk-chatis being looked at, and DGU is already very far behind on the gem.Visual Changes
The inverse header component examples have changed as they now use the
headingcomponent which has slightly different spacing - I did use thepadding: trueoption to try and make them visually similar to how the previous examples looked but I don't think there's a need to make them look exactly the same, as they're just examples of how the component can look instead of how it should look.