fix CMake compiler option handling #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19fb1aa to
c2c2fbf
Compare
This is the replacement PR for alpaka-group#989 Currenlty we split very often the compiler option and the argument. This creates issues when the compiler parses the given arguments. The fix is that the compiler option and argument will be passed with `=` instead of a space in between.
c2c2fbf to
68c30f4
Compare
BenjaminW3
approved these changes
Apr 29, 2020
|
From my point of view this can be merged. Do you want to try this with any other external repositories (PIConGPU)? |
It can be merged. I tested it with the upcoming release branch of PIConGPU. This PR is compatible with the separable compile issue and allow to use remove duplication on the flag list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the replacement PR for #989
Currenlty we split very often the compiler option and the argument.
This creates issues when the compiler parses the given arguments.
The fix is that the compiler option and argument will be passed with
=insteadof a space in between.
The bug is triggered if a cmake script removes duplicated flags with
list(REMOVE_DUPLICATES CUDA_NVCC_FLAGS)ref