CMake CUDA: Cleanups & CCache #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gencode: use no-space syntax; this confuses CCache<4.0 (all available releases today) and is complicating deduplication operations on lists - min CXX standard in CUDA: technically the right thing to set this as well for the CMake CUDA C++ language
CUDA meta-features were introduced with CMake 3.17, see: [https://blog.kitware.com/cmake-3-17-0-rc3-is-ready-for-testing/](https://blog.kitware.com/cmake-3-17-0-rc3-is-ready-for-testing/).
mic84
approved these changes
Jun 2, 2020
ax3l
commented
Jun 8, 2020
| target_compile_features(amrex PUBLIC cxx_std_11) # minimum: C++11 | ||
|
|
||
| if (ENABLE_CUDA AND (CMAKE_VERSION VERSION_GREATER_EQUAL 3.17) ) | ||
| set_target_properties(amrex PROPERTIES CUDA_EXTENSIONS OFF) | ||
| target_compile_features(amrex PUBLIC cuda_std_11) # minimum: C++11 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
This change was already committed 6 days ago, was it not?
There was a problem hiding this comment.
Yes, I was just a confused fellow and forgot you already caught the version guard during review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now AMReX + CMake 3.17 + CUDA works with CCache 3.7.9 (more cross-links, more). Since this is a severe productivity plus I label this "install" + "performance" ;-)
Note: downstream projects might want to add this to their
CMakeLists.txt:CCache does not support Fortran.