set version to 0.5.0-rc1 #3196

psychocoderHPC · 2020-03-03T09:23:33Z

ATTENTION: the rc1 release branch is the destination not dev

PrometheusPi

The ax3l repo is still used in various places. Should this stay this way? (If not, I will approve this pull request.)

PrometheusPi · 2020-03-05T09:23:42Z

share/picongpu/dockerfiles/ubuntu-1604/Singularity

@@ -1,10 +1,10 @@
 Bootstrap: docker
-From: ax3l/picongpu:0.5.0
+From: ax3l/picongpu:0.5.0-rc1


 %labels
 Maintainer Axel Huebl <a.huebl@hzdr.de>


@psychocoderHPC Should @ax3l stay the maintainer or should it shift to you?

I added this to the todo list: https://github.com/ComputationalRadiationPhysics/picongpu/projects/25
I changed the version with our version changing tool, I would keep it "wrong" because I assume @ax3l 's docker image points to the dev branch. @ax3l is this correct?

Let us wait with merging for a reply of @ax3l to know how he handled it in the past.

Usually the container images and :tag that I upload correspond to the release, while :latest then also points to the last release.

We do not distribute the singularity container on our own, as you can see this is just a plain old import from the Dockerfile. But Nvidia distributes a singularity container that way via NGC, which they build on their own with this.

Don't forget to shoot an e-mail to @AdamSimpson (please CC me on it) when the release is done and a new docker image is pushed to dockerhub, so he can update it on NGC (as well as the singularity container build from it). We usually do this after the release, so in a couple of weeks from now.

PrometheusPi · 2020-03-05T09:24:16Z

share/picongpu/dockerfiles/ubuntu-1604/Singularity

@@ -1,10 +1,10 @@
 Bootstrap: docker
-From: ax3l/picongpu:0.5.0


This should be pointing to anther repo not ax3l

PrometheusPi · 2020-03-05T09:24:48Z

share/picongpu/dockerfiles/README.rst

@@ -56,20 +56,20 @@ You can also push the result to dockerhub and singularity-hub (you need an accou
    cd ubuntu-1604

    # docker image
-    docker build -t ax3l/picongpu:0.5.0 .
+    docker build -t ax3l/picongpu:0.5.0-rc1 .


ax3l repo su still used. Is this correct?

PrometheusPi · 2020-03-05T09:25:02Z

share/picongpu/dockerfiles/README.rst

@@ -25,7 +25,7 @@ This exposes the ISAAC port to connect via the webclient to.
 .. code:: bash

    docker pull ax3l/picongpu
-    docker run --runtime=nvidia -p 2459:2459 -t ax3l/picongpu:0.5.0 lwfa_live
+    docker run --runtime=nvidia -p 2459:2459 -t ax3l/picongpu:0.5.0-rc1 lwfa_live


ax3l repo is still used

Please tell me if you (e.g. @PrometheusPi and @psychocoderHPC ) create a dockerhub account.
I already reserved a picongpu/ org a while back and will then add you to it :)
https://hub.docker.com/orgs/picongpu

"Register now and increase the bus-factor by a three-fold."™

@ax3l I am now registered at docker.com as psychocoderhpc

ax3l · 2020-03-05T17:54:44Z

share/picongpu/dockerfiles/ubuntu-1604/Dockerfile

@@ -6,7 +6,7 @@ ENV        DEBIAN_FRONTEND=noninteractive \
           FORCE_UNSAFE_CONFIGURE=1 \
           SPACK_ROOT=/usr/local \
           SPACK_EXTRA_REPO=/usr/local/share/spack-repo \
-           PIC_PACKAGE='picongpu@0.5.0+isaac backend=cuda'
+           PIC_PACKAGE='picongpu@0.5.0-rc1+isaac backend=cuda'


This tag here is the tag you provide in our spack repo.

So add this in its packages/picongpu/package.py before you can build.

ax3l · 2020-03-05T18:03:00Z

share/picongpu/dockerfiles/ubuntu-1604/Dockerfile

@@ -6,7 +6,7 @@ ENV        DEBIAN_FRONTEND=noninteractive \
           FORCE_UNSAFE_CONFIGURE=1 \


Above: the MAINTAINER labels seams to be deprecated now in Docker. Just use:

LABEL maintainer="Rene Widera <r.widera@hzdr.de>, Axel Huebl <a.huebl@hzdr.de>"

ax3l · 2020-03-06T02:03:33Z

share/picongpu/dockerfiles/ubuntu-1604/Singularity

@@ -1,10 +1,10 @@
 Bootstrap: docker
-From: ax3l/picongpu:0.5.0
+From: ax3l/picongpu:0.5.0-rc1


 %labels
 Maintainer Axel Huebl <a.huebl@hzdr.de>


This seams to work here, too:

Suggested change

Maintainer Axel Huebl <a.huebl@hzdr.de>

Maintainer "Rene Widera <r.widera@hzdr.de>, Axel Huebl <a.huebl@hzdr.de>"

I hoped that it is not coming to the point that I need to maintain the docker too^^
I will work on all the docker stuff end of next week.

PrometheusPi · 2020-04-22T10:36:31Z

@psychocoderHPC what is the status of this pull request?

psychocoderHPC · 2020-04-22T10:52:17Z

Last time I got spack issue during OpenMPI was compiled. I have currently no time to look into it.

psychocoderHPC · 2020-04-24T09:20:10Z

currently my docker tests ended with:

[ 95%] Building NVCC (Device) object CMakeFiles/picongpu.dir/picongpu_generated_main.cpp.o
nvcc fatal   : Unknown option '-diag_suppress'
CMake Error at picongpu_generated_versionFormat.cpp.o.Release.cmake:220 (message):
  Error generating
  /opt/picInputs/lwfa/.build/CMakeFiles/picongpu.dir//./picongpu_generated_versionFormat.cpp.o


CMakeFiles/picongpu.dir/build.make:87: recipe for target 'CMakeFiles/picongpu.dir/picongpu_generated_versionFormat.cpp.o' failed
make[2]: *** [CMakeFiles/picongpu.dir/picongpu_generated_versionFormat.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
nvcc fatal   : Unknown option '-diag_suppress'
CMake Error at picongpu_generated_main.cpp.o.Release.cmake:220 (message):
  Error generating
  /opt/picInputs/lwfa/.build/CMakeFiles/picongpu.dir//./picongpu_generated_main.cpp.o

psychocoderHPC · 2020-04-24T19:28:24Z

currently my docker tests ended with:

[ 95%] Building NVCC (Device) object CMakeFiles/picongpu.dir/picongpu_generated_main.cpp.o
nvcc fatal   : Unknown option '-diag_suppress'
CMake Error at picongpu_generated_versionFormat.cpp.o.Release.cmake:220 (message):
  Error generating
  /opt/picInputs/lwfa/.build/CMakeFiles/picongpu.dir//./picongpu_generated_versionFormat.cpp.o


CMakeFiles/picongpu.dir/build.make:87: recipe for target 'CMakeFiles/picongpu.dir/picongpu_generated_versionFormat.cpp.o' failed
make[2]: *** [CMakeFiles/picongpu.dir/picongpu_generated_versionFormat.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
nvcc fatal   : Unknown option '-diag_suppress'
CMake Error at picongpu_generated_main.cpp.o.Release.cmake:220 (message):
  Error generating
  /opt/picInputs/lwfa/.build/CMakeFiles/picongpu.dir//./picongpu_generated_main.cpp.o

OK I think I found the issue. We have a broken alpaka CMake file. I will fix it directly in the subtree (third party folder). This will simplify later the merge from master into dev (less conflicts compared to a subtree update with a fixed alpaka).

psychocoderHPC · 2020-04-24T19:29:31Z

We need to release ISAAC before this release, else the spack recipe will not work.

psychocoderHPC · 2020-04-28T18:24:15Z

I found the problem, I found a workaround but this workaround broke windows compile with separate compile enabled.
But the real problem why -Xcudafe was removed when it was multiple times used as option is an issue in ISAAC. ISAAC removes duplicated options in CUDA_NVCC_FLAGS see here

psychocoderHPC · 2020-04-29T08:57:26Z

For documentation: a fix of alpaka CMake ref would solve the issue. Never the less I will remove the critical option in ISAAC instead of changing the alpaka cmake. The reason is that ISAAC is not adding any option to CUDA_NVCC_FLAGS thus it should not manipulate the cmake variable.

sbastrakov · 2020-05-06T11:31:35Z

Is it now ready for another review?

psychocoderHPC · 2020-05-06T11:43:37Z

Yes can be merged now. ISAAC 1.5.0 is released which fixes all issues. I will update the spack recipes after we released PIConGPU

sbastrakov

Not pressing merge right now, maybe @PrometheusPi would like to have another look.

psychocoderHPC · 2020-05-11T11:33:00Z

@sbastrakov you can merge it, there will be another PR too to change the version to 0.5.0 later.

psychocoderHPC added the documentation regarding documentation or wiki discussions label Mar 3, 2020

psychocoderHPC added this to the 0.5.0 milestone Mar 3, 2020

psychocoderHPC requested a review from PrometheusPi March 5, 2020 09:19

psychocoderHPC assigned PrometheusPi Mar 5, 2020

PrometheusPi requested changes Mar 5, 2020

View reviewed changes

ax3l reviewed Mar 5, 2020

View reviewed changes

ax3l reviewed Mar 6, 2020

View reviewed changes

psychocoderHPC mentioned this pull request Apr 27, 2020

fix CMake compiler option handling alpaka-group/alpaka#989

Closed

psychocoderHPC mentioned this pull request Apr 29, 2020

cmake: remove manipulation of CUDA_NVCC_FLAGS ComputationalRadiationPhysics/isaac#101

Merged

set version to 0.5.0-rc1

d7e1317

psychocoderHPC force-pushed the topic-versionUpdateTo0.5.0-rc1 branch from e9d3a17 to d7e1317 Compare May 4, 2020 14:48

sbastrakov approved these changes May 6, 2020

View reviewed changes

sbastrakov merged commit b3e34c6 into ComputationalRadiationPhysics:release-0.5.0-rc1 May 12, 2020

psychocoderHPC deleted the topic-versionUpdateTo0.5.0-rc1 branch May 13, 2020 07:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set version to 0.5.0-rc1 #3196

set version to 0.5.0-rc1 #3196

psychocoderHPC commented Mar 3, 2020 •

edited

Loading

PrometheusPi left a comment

PrometheusPi Mar 5, 2020

psychocoderHPC Mar 5, 2020

psychocoderHPC Mar 5, 2020 •

edited by PrometheusPi

Loading

ax3l Mar 5, 2020

PrometheusPi Mar 5, 2020

PrometheusPi Mar 5, 2020

PrometheusPi Mar 5, 2020

ax3l Mar 5, 2020

ax3l Apr 2, 2020

psychocoderHPC Apr 24, 2020

ax3l Mar 5, 2020 •

edited

Loading

ax3l Mar 5, 2020

ax3l Mar 6, 2020

psychocoderHPC Mar 6, 2020

PrometheusPi commented Apr 22, 2020

psychocoderHPC commented Apr 22, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 28, 2020

psychocoderHPC commented Apr 29, 2020

sbastrakov commented May 6, 2020

psychocoderHPC commented May 6, 2020

sbastrakov left a comment

psychocoderHPC commented May 11, 2020

		@@ -6,7 +6,7 @@ ENV DEBIAN_FRONTEND=noninteractive \
		FORCE_UNSAFE_CONFIGURE=1 \

	Maintainer Axel Huebl <a.huebl@hzdr.de>
	Maintainer "Rene Widera <r.widera@hzdr.de>, Axel Huebl <a.huebl@hzdr.de>"

set version to 0.5.0-rc1 #3196

set version to 0.5.0-rc1 #3196

Conversation

psychocoderHPC commented Mar 3, 2020 • edited Loading

PrometheusPi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psychocoderHPC Mar 5, 2020 • edited by PrometheusPi Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ax3l Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PrometheusPi commented Apr 22, 2020

psychocoderHPC commented Apr 22, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 24, 2020

psychocoderHPC commented Apr 28, 2020

psychocoderHPC commented Apr 29, 2020

sbastrakov commented May 6, 2020

psychocoderHPC commented May 6, 2020

sbastrakov left a comment

Choose a reason for hiding this comment

psychocoderHPC commented May 11, 2020

psychocoderHPC commented Mar 3, 2020 •

edited

Loading

psychocoderHPC Mar 5, 2020 •

edited by PrometheusPi

Loading

ax3l Mar 5, 2020 •

edited

Loading