Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations to clarify which documents can be uploaded #7210

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

larssondenise
Copy link
Contributor

@larssondenise larssondenise commented Nov 18, 2024

Describe the background of your pull request

What does your pull request do? Does it solve a bug (which one?), add a feature?

Additional context

Add any other context

Governance

  • Documentation is added
  • Test cases are added or updated

By submitting this pull request I confirm that:

Summary by CodeRabbit

  • New Features
    • Enhanced clarity in user interface text strings, improving instructions and descriptions.
    • Updated file upload helper text to specify supported file types (Word, PDF, Excel, images) and size limit (15 MB).
    • Simplified description for creating a Virtual Contributor.

@larssondenise larssondenise requested review from hero101 and ccanos and removed request for hero101 November 18, 2024 08:41
Copy link

coderabbitai bot commented Nov 18, 2024

Walkthrough

The changes in this pull request involve updates to the translation.en.json file, which contains text strings for the user interface. Modifications include clarifying phrases, enhancing the helper text for file uploads, and refining descriptions related to the creation of a Virtual Contributor. The overall goal is to improve clarity and consistency in the language used throughout the application, making it more intuitive for users.

Changes

File Change Summary
src/core/i18n/en/translation.en.json - Updated "Add link to {{title}}" to "Add links or documents to {{title}}".
- Revised helper text to specify upload options: "You can upload Word, PDF, Excel, or images up to 15 MB".
- Changed "Written knowledge in text and documents" to "Written knowledge in text".
- Minor adjustments to tooltips and confirmation dialogs for improved clarity.

Possibly related PRs

Suggested labels

client, translations

Suggested reviewers

  • SimoneZaza

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cb513c7 and c4491b5.

📒 Files selected for processing (1)
  • src/core/i18n/en/translation.en.json (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/core/i18n/en/translation.en.json (1)

Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.

🔇 Additional comments (2)
src/core/i18n/en/translation.en.json (2)

708-708: LGTM! The text change improves clarity.

The updated text better reflects the functionality by explicitly mentioning both links and documents.


1448-1448: LGTM! The helper text now provides clear upload guidelines.

The updated text improves user experience by explicitly stating supported file types and size limits upfront.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@larssondenise larssondenise linked an issue Nov 18, 2024 that may be closed by this pull request
3 tasks
@ccanos ccanos merged commit 49a53e8 into develop Nov 18, 2024
3 checks passed
@ccanos ccanos deleted the client-7209 branch November 18, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion around files that can be upload
2 participants