Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying an ActorSystem when [FixtureLifeCycle(LifeCycle.InstancePerTestCase)] is specified #44

Closed
mchandschuh opened this issue Jul 14, 2022 · 1 comment · Fixed by #56
Closed

Support specifying an ActorSystem when [FixtureLifeCycle(LifeCycle.InstancePerTestCase)] is specified #44

mchandschuh opened this issue Jul 14, 2022 · 1 comment · Fixed by #56

Comments

@mchandschuh
Copy link

nunit 3.13 added [FixtureLifeCycle(LifeCycle.InstancePerTestCase)] which should obviate the need for code bombing when an ActorSystem is provided to the TestKit constructor.

Describe the bug

  • Unable to specify ActorSystem in TestKit constructor

To Reproduce

  • Try instantiating TestKit with an ActorSystem

See: akkadotnet/akka.net#1092
@eaba
Copy link
Contributor

eaba commented Jul 15, 2022 •
edited
Loading

Tell me more if it is not the right thing @mchandschuh #45

Aaronontheweb added a commit to Aaronontheweb/Akka.TestKit.Nunit that referenced this issue Jul 21, 2022
@Aaronontheweb
close akkadotnet#44
40ae8d2 
Cleaned up legacy bits
@Aaronontheweb Aaronontheweb mentioned this issue Jul 21, 2022
Merged
3 tasks
Aaronontheweb added a commit that referenced this issue Jul 22, 2022
@Aaronontheweb
Fix/44 ActorSystem lifecycle (#56)
1320e27 
* fixed code bomb assertions

* close #44

Cleaned up legacy bits

* implemented bugfix suggestions
@Aaronontheweb Aaronontheweb mentioned this issue Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/44 ActorSystem lifecycle Aaronontheweb/Akka.TestKit.Nunit
2 participants
@mchandschuh @eaba