Fix/44 ActorSystem lifecycle
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up legacy bits
Aaronontheweb
commented
Jul 21, 2022
| namespace Akka.TestKit.NUnit.Tests; | ||
|
|
||
| [TestFixture] | ||
| public class Bugfix44Spec : TestKit |
There was a problem hiding this comment.
Repro spec for #44
| @@ -23,7 +23,6 @@ public class TestKit : TestKitBase, IDisposable | |||
| private static readonly NUnitAssertions _assertions = new NUnitAssertions(); | |||
| private readonly Config _config; | |||
| private readonly string _actorSystemName; | |||
| private bool _isFirstRun = true; | |||
| @@ -35,8 +34,6 @@ public class TestKit : TestKitBase, IDisposable | |||
| public TestKit(ActorSystem system = null) | |||
| : base(_assertions, system) | |||
| { | |||
| if(system != null) | |||
| /// creating and setting up the ActorSystem. | ||
| /// </summary> | ||
| [SetUp] | ||
| public void InitializeActorSystemOnSetUp() |
There was a problem hiding this comment.
Setup no longer needed now that this can be done from ActorSystem constructor.
|
@Aaronontheweb -- any estimate on this being merged/released? |
mchandschuh
reviewed
Jul 22, 2022
|
@mchandschuh I was just waiting for your approval. Now that it's done I can push it any time. |
|
@Aaronontheweb -- I was expecting a new |
|
@Aaronontheweb @eaba -- thanks guys! This was successfully integrated! As a note -- any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
Changes
Removed all of the old hacks we needed to do in order to make the NUnit testkit behave like the xUnit test kit (to provide isolated
ActorSystems on each test.)Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
cc @mchandschuh