FixtureLifeCycle #45
Closed
FixtureLifeCycle #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is all that's needed!! |
|
are we able to do a release following this merge? |
mchandschuh
reviewed
Jul 19, 2022
| @@ -2,15 +2,15 @@ | |||
| <Import Project="..\common.props" /> | |||
| <PropertyGroup> | |||
| <AssemblyTitle>Akka.TestKit.NUnit.Tests</AssemblyTitle> | |||
| <TargetFrameworks>net45;netcoreapp2.0</TargetFrameworks> | |||
| <TargetFrameworks>net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
I'm assuming this is overridden when building packages?
mchandschuh
reviewed
Jul 19, 2022
| <IsPackable>true</IsPackable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Akka.TestKit" Version="$(AkkaTestKitVersion)" /> | ||
| <PackageReference Include="Akka.TestKit" Version="1.4.39" /> |
There was a problem hiding this comment.
should probably maintain the msbuild property reference here
|
@eaba -- closed without comment? what's the story here? |
|
@mchandschuh this code was included in PR #47 which was merged in. I'm reviewing these changes now and prepping an update for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@mchandschuh
nunit 3.13 added [FixtureLifeCycle(LifeCycle.InstancePerTestCase)] which should obviate the need for code bombing when an ActorSystem is provided to the TestKit constructor.
Describe the bug
To Reproduce
See: akkadotnet/akka.net#1092