Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination redshift: Remove encrypted staging option #39141

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Destination redshift: Remove encrypted staging option #39141

merged 1 commit into from
Jun 26, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jun 5, 2024 •
edited
Loading

discovered in https://github.com/airbytehq/oncall/issues/5422

this option has never worked. It was added in #14013, which copied the Snowflake SQL syntax from #12452. Redshift's SQL incantation is slightly different; attempting to use this option results in a syntax error.

Let's just remove the option for now (it has never worked, and nobody is currently using it). I submitted https://github.com/airbytehq/airbyte-internal-issues/issues/8164 to fix it, but... nobody is exactly clamoring for this feature, so 🤷

(I reserve the right to delete the relevant code in a later PR in this stack, but leaving it as-is for now)

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 4:38pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 5, 2024
This was referenced Jun 5, 2024
Merged
Merged
@edgao Graphite App
Copy link
Contributor Author

edgao commented Jun 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

@edgao edgao mentioned this pull request Jun 5, 2024
Merged
@edgao edgao marked this pull request as ready for review June 5, 2024 21:07
@edgao edgao requested a review from a team as a code owner June 5, 2024 21:07
@octavia-squidington-iv octavia-squidington-iv requested a review from a team June 5, 2024 21:08
@edgao edgao mentioned this pull request Jun 6, 2024
Closed
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from d0495a9 to 91123ed Compare June 7, 2024 00:01
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from d0273c2 to 3d0e7d3 Compare June 7, 2024 00:01
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 91123ed to 769fb16 Compare June 7, 2024 00:06
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 3d0e7d3 to 026cf75 Compare June 7, 2024 00:06
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 769fb16 to 4c815f2 Compare June 7, 2024 15:15
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 026cf75 to 2e369fc Compare June 7, 2024 15:15
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 4c815f2 to 6486614 Compare June 7, 2024 16:33
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 2e369fc to f7a341e Compare June 7, 2024 16:33
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 6486614 to 52effe1 Compare June 12, 2024 18:16
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from f7a341e to c8a8803 Compare June 12, 2024 18:17
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 52effe1 to a629806 Compare June 12, 2024 19:39
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from c8a8803 to f2e7dca Compare June 12, 2024 19:40
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from a629806 to 7b7e9d4 Compare June 13, 2024 15:30
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from f2e7dca to 39746f3 Compare June 13, 2024 15:31
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 7b7e9d4 to c7bc16b Compare June 13, 2024 15:46
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 39746f3 to 88f703f Compare June 13, 2024 15:46
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from c7bc16b to b89aa67 Compare June 14, 2024 18:06
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from c783a09 to 6776c9c Compare June 18, 2024 17:34
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from ec8d683 to de53471 Compare June 18, 2024 17:34
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 6776c9c to a4c065e Compare June 18, 2024 17:44
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from de53471 to a62804b Compare June 18, 2024 17:45
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from a4c065e to ba84a5a Compare June 18, 2024 19:58
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from a62804b to 77a62d5 Compare June 18, 2024 19:59
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from ba84a5a to 07e77e8 Compare June 18, 2024 22:39
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 77a62d5 to 12b3d84 Compare June 18, 2024 22:39
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 07e77e8 to 5ab2266 Compare June 18, 2024 23:25
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 12b3d84 to a0a9aab Compare June 18, 2024 23:25
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 5ab2266 to 8e2fa50 Compare June 20, 2024 15:08
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from a0a9aab to 4cb52bc Compare June 20, 2024 15:08
@edgao edgao mentioned this pull request Jun 21, 2024
Merged
@edgao edgao force-pushed the edgao/redshift_test_kotlin_conversion branch from 8e2fa50 to 326d11e Compare June 25, 2024 22:58
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from 4cb52bc to b7434d0 Compare June 25, 2024 22:58
Base automatically changed from edgao/redshift_test_kotlin_conversion to master June 26, 2024 16:32
@edgao edgao force-pushed the edgao/redshift_remove_encryption_option branch from b7434d0 to cd415ea Compare June 26, 2024 16:33
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 26, 2024
@edgao edgao enabled auto-merge (squash) June 26, 2024 16:34
@edgao edgao merged commit 1f0da7f into master Jun 26, 2024
30 of 31 checks passed
@edgao edgao deleted the edgao/redshift_remove_encryption_option branch June 26, 2024 16:54
This was referenced Jun 26, 2024
Merged
Merged
Merged
Merged
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
@edgao @xiaohansong
Destination redshift: Remove encrypted staging option (#39141)
1855fb8
@edgao edgao mentioned this pull request Jul 26, 2024
Merged
@edgao edgao mentioned this pull request Aug 14, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgao @evantahler @gisripa @octavia-squidington-iii