remove encrypted s3 staging option

airbytehq · Jun 5, 2024 · d0273c2 · d0273c2
1 parent d0495a9
commit d0273c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 43 deletions.
diff --git a/...io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt b/...io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt
@@ -141,6 +141,9 @@ class RedshiftS3StagingSqlOperations(
             if (keyEncryptingKey == null) {
                 ""
             } else {
+                // TODO This is broken (it's using Snowflake SQL syntax).
+                // Leaving it here since the rest of the plumbing seems reasonable,
+                // but we should fix this eventually.
                 String.format(
                     " encryption = (type = 'aws_cse' master_key = '%s')",
                     BASE64_ENCODER.encodeToString(keyEncryptingKey)

diff --git a/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json b/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json
@@ -180,49 +180,6 @@
                 "description": "Whether to delete the staging files from S3 after completing the sync. See <a href=\"https://docs.airbyte.com/integrations/destinations/redshift/#:~:text=the%20root%20directory.-,Purge%20Staging%20Data,-Whether%20to%20delete\"> docs</a> for details.",
                 "default": true,
                 "order": 6
-              },
-              "encryption": {
-                "title": "Encryption",
-                "type": "object",
-                "description": "How to encrypt the staging data",
-                "default": { "encryption_type": "none" },
-                "oneOf": [
-                  {
-                    "title": "No encryption",
-                    "description": "Staging data will be stored in plaintext.",
-                    "type": "object",
-                    "required": ["encryption_type"],
-                    "properties": {
-                      "encryption_type": {
-                        "type": "string",
-                        "const": "none",
-                        "enum": ["none"],
-                        "default": "none"
-                      }
-                    }
-                  },
-                  {
-                    "title": "AES-CBC envelope encryption",
-                    "description": "Staging data will be encrypted using AES-CBC envelope encryption.",
-                    "type": "object",
-                    "required": ["encryption_type"],
-                    "properties": {
-                      "encryption_type": {
-                        "type": "string",
-                        "const": "aes_cbc_envelope",
-                        "enum": ["aes_cbc_envelope"],
-                        "default": "aes_cbc_envelope"
-                      },
-                      "key_encrypting_key": {
-                        "type": "string",
-                        "title": "Key",
-                        "description": "The key, base64-encoded. Must be either 128, 192, or 256 bits. Leave blank to have Airbyte generate an ephemeral key for each sync.",
-                        "airbyte_secret": true
-                      }
-                    }
-                  }
-                ],
-                "order": 7
               }
             }
           }