Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live: Drop patterns-yast-yast2_basis requirement #1893

Merged

Conversation

g7
Copy link
Contributor

@g7 g7 commented Jan 13, 2025

Problem

patterns-yast is not available in SLFO/SLE16.

Solution

Added a requirement for the pattern only when using the openSUSE, openSUSE-PXE, Leap and Leap-PXE profiles.

As suggested by Josef below, dropped it entirely on openSUSE as well as the whole pattern shouldn't be installed at all.

@g7 g7 force-pushed the epaolantonio/live-slfo-yast-patterns branch from 217ad3a to ae12f50 Compare January 13, 2025 17:18
@jreidinger
Copy link
Contributor

@g7 Thanks for patch, but as it is just about media content and also yast packages should be installed per package and not as whole pattern, I would remove it also from opensuse medium ( so please update PR ).
And one more question I have is why SLE does not have PXE? I get few question and I have no clue. We should be able to easily add it same as for opensuse one.

yast packages should be installed per package and not as
a whole pattern.

Signed-off-by: Eugenio Paolantonio <eugenio.paolantonio@suse.com>
@g7 g7 force-pushed the epaolantonio/live-slfo-yast-patterns branch from ae12f50 to c68c2f3 Compare January 15, 2025 16:56
@g7 g7 changed the title live: Require patterns-yast-yast2_basis only on openSUSE and Leap profiles live: Drop patterns-yast-yast2_basis requirement Jan 15, 2025
@g7
Copy link
Contributor Author

g7 commented Jan 15, 2025

Thanks for the review!

v2:

  • As suggested, drop the pattern requirement everywhere, not only in SLES.
  • Rebased on latest master

And one more question I have is why SLE does not have PXE? I get few question and I have no clue. We should be able to easily add it same as for opensuse one.

I've passed this question on, it's something that I would expect too to be honest, but let's see.

Thanks!

@jreidinger jreidinger merged commit 6411b46 into agama-project:master Jan 16, 2025
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants