Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(live): Improve Makefile for building the Live ISO #1928

Merged
merged 2 commits into from
Feb 7, 2025
Merged

feat(live): Improve Makefile for building the Live ISO #1928

merged 2 commits into from
Feb 7, 2025

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jan 21, 2025

Improvements

  • Allow building the SLE image (using internal OBS)
  • Allow passing extra parameters to OSC build (like preferred RPMs)
  • Updated documentation
    • Documented the new features
    • Removed outdated Cockpit section
    • Unified heading style

@lslezak
Improve Makefile for building the Live ISO
f7ebb02 
- Allow building the SLE image (using internal OBS)
- Allow passing extra parameters to OSC build (like preferred RPMs)
- Updated documentation
@lslezak
Allow even more customizations
4629001
@lslezak lslezak marked this pull request as ready for review February 7, 2025 12:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13200012423

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 70.888%
Files with Coverage Reduction New Missed Lines %
rust/agama-server/tests/common/mod.rs 5 74.19%
Totals Coverage Status
Change from base Build 13198839713: -0.02%
Covered Lines: 17291
Relevant Lines: 24392
💛 - Coveralls

@lslezak lslezak merged commit 6311784 into master Feb 7, 2025
8 of 9 checks passed
@lslezak lslezak deleted the live_build branch February 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @imobachgs